Closed
Conversation
Contributor
|
ACK |
Member
|
Does this break connecting to multiple nodes on different ports? eg, multiple local bitcoinds |
Member
Author
|
All nodes have a self-generated unique 64-bit identifier. This patch will prevent two connections to a partner with the same identifier. Running two nodes on one system and connecting to both should not be a problem. |
Member
|
Per https://en.bitcoin.it/wiki/Protocol_specification#version the nonce is unique for every version message, so this would imply a protocol change making it static per client... |
Member
Author
|
Nice catch; that makes this problem somewhat harder to solve. Closing for now... |
destenson
pushed a commit
to destenson/bitcoin--bitcoin
that referenced
this pull request
Jun 26, 2016
If we want to be compatible to 12.0 on network layer we need them back in ppszTypeName[] to keep inv type consistent (allNetMessageTypes[] should not have them, we shouldn't accept non-implmented messages)
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Nov 4, 2017
test_bitcoin enhancements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of IPv6 support: prevent double connections to the same node.
Not urgent.