[WIP][depends] ZeroMQ 4.1.5 && ZMQ on Windows#8238
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jul 30, 2016
Merged
Conversation
fanquake
force-pushed
the
depends-zeromq-4-1-5
branch
from
58ad9ec to
df23115
Compare
fanquake
force-pushed
the
depends-zeromq-4-1-5
branch
5 times, most recently
from
dc760be to
8c7c5a5
Compare
Contributor
|
Nice. |
Contributor
|
Compiled successfully on all three platforms: https://bitcoin.jonasschnelli.ch/pulls/8238/ |
Member
Author
|
@achow101 Given you opened #7943, are you able to download one of @jonasschnelli's test binaries and try using ZMQ ? |
Member
|
@fanquake looks like it works on windows now. |
Member
|
Concept ACK |
Member
|
Concept ACK. I'd prefer going a slightly different route, though. Upstream removed the mingw requirement here: zeromq/libzmq@9114d39 and a fixup here: zeromq/libzmq@9e6745c . I'd prefer to take those patches directly. Then we can simply drop the patches when we update to a release that includes them. |
Member
|
@fanquake Please have a look at theuni@a8d5faa . That takes the upstream commits, as well as disabling curve, which was necessary for me locally. |
fanquake
force-pushed
the
depends-zeromq-4-1-5
branch
from
8c7c5a5 to
6a08416
Compare
Member
Author
|
Updated with @theuni's suggestions |
Member
Author
|
Can someone on Windows @achow101, retest this? |
Member
|
ACK 6a08416c5c1955a2ccec9bf393d829e1a4c34892 |
fanquake
force-pushed
the
depends-zeromq-4-1-5
branch
from
6a08416 to
a615386
Compare
laanwj
added a commit
that referenced
this pull request
Jul 30, 2016
a615386 [depends] ZeroMQ 4.1.5 (fanquake)
18 tasks
This was referenced Sep 2, 2016
Closed
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 9, 2017
Add ZeroMQ notifications Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6103 - bitcoin/bitcoin#6684 - bitcoin/bitcoin#6686 - bitcoin/bitcoin#6736 - bitcoin/bitcoin#6739 - bitcoin/bitcoin#6743 - bitcoin/bitcoin#6768 - bitcoin/bitcoin#6779 - bitcoin/bitcoin#6810 - bitcoin/bitcoin#6927 - bitcoin/bitcoin#6980 (only upgrading zeromq) - bitcoin/bitcoin#6680 - bitcoin/bitcoin#7058 - bitcoin/bitcoin#7621 - bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7762 - bitcoin/bitcoin#7993 (only upgrading zeromq) - bitcoin/bitcoin#8238 - bitcoin/bitcoin#8701 - bitcoin/bitcoin#6685 Closes #2020.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 9, 2017
Add ZeroMQ notifications Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6103 - bitcoin/bitcoin#6684 - bitcoin/bitcoin#6686 - bitcoin/bitcoin#6736 - bitcoin/bitcoin#6739 - bitcoin/bitcoin#6743 - bitcoin/bitcoin#6768 - bitcoin/bitcoin#6779 - bitcoin/bitcoin#6810 - bitcoin/bitcoin#6927 - bitcoin/bitcoin#6980 (only upgrading zeromq) - bitcoin/bitcoin#6680 - bitcoin/bitcoin#7058 - bitcoin/bitcoin#7621 - bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7762 - bitcoin/bitcoin#7993 (only upgrading zeromq) - bitcoin/bitcoin#8238 - bitcoin/bitcoin#8701 - bitcoin/bitcoin#6685 Closes #2020.
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 8, 2018
a615386 [depends] ZeroMQ 4.1.5 (fanquake)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to revive the work started by @theuni in #6819, and hopefully close issues #7943 and #6681.
Even if we still can't fix the Windows linking issues, it might be worth moving to the newer ZeroMQ version. Release notes as follows:
The changes to enable static linking in ZeroMQ have been made in #1615 and then a follow up in #1978 / #1979.
We no longer need the headergaurd patch from #6819, as those changes seem to be in src/windows.hpp. Introduced in #901.
Hopefully pulling all this info together means we can get this working.