Check if the macro PKG_PROG_PKG_CONFIG was expanded.#8242
Check if the macro PKG_PROG_PKG_CONFIG was expanded.#8242paveljanik wants to merge 1 commit intobitcoin:masterfrom
Conversation
If pkg-config is not installed, pkg-config's pkg.m4 is not installed and thus the macro PKG_PROG_PKG_CONFIG is not expanded. Fixes bitcoin#8228.
|
Tested on OS X with |
|
pkg-config isn't required for win32. The fact that it is in some places atm is a bug. |
|
While I generally support making as much as possible optional, I see no value in pkg-config (or pkgconf) being optional. |
|
@luke-jr reason being that it sometimes does more harm than good on Windows. But I suppose at this point we may be over-complicating things by trying to avoid the dependency. Maybe we'd be better off requiring it everywhere, and just not using it for Windows. |
|
@theuni I do not like requiring it where we do not need it. If we do not use it, it is more difficult to start compiling the source code (one more tool to install/workaround). If this change makes |
|
Or just require and it everywhere, including Windows... only pkgconf problems I'm aware of were fixed years ago. |
|
@luke-jr Yes, this is the status-quo as of now. |
|
Closing. Not needed now after #8314. |
If
pkg-configis not installed,pkg-config'spkg.m4is not installed and thus the macroPKG_PROG_PKG_CONFIGis not expanded.Fixes #8228.
With this change, the output without
pkg-configinstalled is: