trivial: capitalize BIP32 in option help#8246
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jun 23, 2016
Merged
Conversation
For consistency, BIP32 should be in uppercase in translation message. Reported by @pryds on Transifex.
Member
|
trivial ACK |
Contributor
|
ACK a1c92c2 I didn't want to be super nit-picky when merging this (there were also bip32s in comments etc.). |
laanwj
added a commit
that referenced
this pull request
Jun 23, 2016
a1c92c2 trivial: capitalize BIP32 in option help (Wladimir J. van der Laan)
Member
Author
Right, this is a user-facing issue, so somewhat more serious. |
Contributor
|
Post merge ACK. |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
a1c92c2 trivial: capitalize BIP32 in option help (Wladimir J. van der Laan)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
a1c92c2 trivial: capitalize BIP32 in option help (Wladimir J. van der Laan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency, BIP32 should be in uppercase in translation message.
Reported by @pryds on Transifex.