src: Fix spelling error in comment - tinyformat.h#8264
Closed
wbnns wants to merge 1 commit intobitcoin:masterfrom
wbnns:bitcoiner-fix-typo-tinyformat
Closed
src: Fix spelling error in comment - tinyformat.h#8264wbnns wants to merge 1 commit intobitcoin:masterfrom wbnns:bitcoiner-fix-typo-tinyformat
wbnns wants to merge 1 commit intobitcoin:masterfrom
wbnns:bitcoiner-fix-typo-tinyformat
Conversation
wbnns
changed the title
Contributor
|
Trivial ACK ea67f3b |
Member
|
Was this typo done upstream? Then it might be a good time to evaluate if syncing with upstream makes sense? |
Member
|
This should be submitted here: https://github.com/c42f/tinyformat |
Author
|
@laanwj Hello, thanks, however, I just checked and it seems there is no typo in their version. |
Member
|
I guess that means we should just sync with upstream.
|
Member
|
Will push a PR to update tinyformat to git head. |
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Jun 27, 2016
Updates `tinyformat.h` to commit c42f/tinyformat@3a33bbf upstream. Makes sure that our local changes are kept: - bitcoin#3767 1b8fd35 Make tinyformat errors raise an exception instead of assert()ing - bitcoin#4735 9b6d4c5 Move strprintf define to tinyformat.h - bitcoin#4748 6e5fd00 include stdexcept (for std::exception) - bitcoin#8000 9eaa0af force USE_VARIADIC_TEMPLATES - Add `std::string format(const std::string &fmt...` added this at the time, as we want to be able to do `strprintf(_(...), ...)` Inspired by bitcoin#8264.
Author
|
@laanwj @sipa @MarcoFalke @paveljanik Thanks guys, for the review and feedback on this PR. 👍 |
Member
zkbot
pushed a commit
to zcash/zcash
that referenced
this pull request
Oct 25, 2016
util: Update tinyformat Updates `tinyformat.h` to commit c42f/tinyformat@3a33bbf upstream. Makes sure that our local changes are kept: - bitcoin/bitcoin#3767 1b8fd35 Make tinyformat errors raise an exception instead of assert()ing - bitcoin/bitcoin#4735 9b6d4c5 Move strprintf define to tinyformat.h - bitcoin/bitcoin#4748 6e5fd00 include stdexcept (for std::exception) - bitcoin/bitcoin#8000 9eaa0af force USE_VARIADIC_TEMPLATES - Add `std::string format(const std::string &fmt...` added this at the time, as we want to be able to do `strprintf(_(...), ...)` Inspired by bitcoin/bitcoin#8264. For Zcash: ref #1349
protonn
pushed a commit
to argentumproject/argentum
that referenced
this pull request
May 7, 2017
Updates `tinyformat.h` to commit c42f/tinyformat@3a33bbf upstream. Makes sure that our local changes are kept: - bitcoin#3767 1b8fd35 Make tinyformat errors raise an exception instead of assert()ing - bitcoin#4735 9b6d4c5 Move strprintf define to tinyformat.h - bitcoin#4748 6e5fd00 include stdexcept (for std::exception) - bitcoin#8000 9eaa0af force USE_VARIADIC_TEMPLATES - Add `std::string format(const std::string &fmt...` added this at the time, as we want to be able to do `strprintf(_(...), ...)` Inspired by bitcoin#8264.
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 3, 2019
Updates `tinyformat.h` to commit c42f/tinyformat@3a33bbf upstream. Makes sure that our local changes are kept: - bitcoin#3767 1b8fd35 Make tinyformat errors raise an exception instead of assert()ing - bitcoin#4735 9b6d4c5 Move strprintf define to tinyformat.h - bitcoin#4748 6e5fd00 include stdexcept (for std::exception) - bitcoin#8000 9eaa0af force USE_VARIADIC_TEMPLATES - Add `std::string format(const std::string &fmt...` added this at the time, as we want to be able to do `strprintf(_(...), ...)` Inspired by bitcoin#8264.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains one commit that fixes a spelling error in one of the in-line comments in
src/tinyformat.h:mimimumshould be spelledminimum