Skip to content

[doc] Docs and copyright headers bump#8286

Closed
maflcko wants to merge 3 commits intobitcoin:masterfrom
maflcko:Mf1607-trivialPre13
Closed

[doc] Docs and copyright headers bump#8286
maflcko wants to merge 3 commits intobitcoin:masterfrom
maflcko:Mf1607-trivialPre13

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jun 29, 2016 •
edited
Loading

No description provided.

@maflcko maflcko added the Docs label Jun 29, 2016
paveljanik
paveljanik reviewed Jul 1, 2016
View reviewed changes
README.md Outdated
Copy link
Contributor

@paveljanik paveljanik Jul 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing dot at the end of sentence.

@paveljanik
Copy link
Contributor

paveljanik commented Jul 1, 2016

ACK everything except copyright bumps.

This PR's review time will be long...

@maflcko
Copy link
Member Author

maflcko commented Jul 1, 2016

@paveljanik You can apply the bump script in contrib/ locally and then diff with my result to see the "actual" diff.

@maflcko maflcko force-pushed the Mf1607-trivialPre13 branch from faa887e to fa05c65 Compare July 1, 2016 09:07
@paveljanik
Copy link
Contributor

paveljanik commented Jul 1, 2016

The script is not portable... On OS X:

date: illegal time format
usage: date [-jnu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ... 
            [-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]

https://github.com/bitcoin/bitcoin/blob/master/src/indirectmap.h doesn't contain copyright header at all.

@maflcko maflcko force-pushed the Mf1607-trivialPre13 branch from fa05c65 to fa8968f Compare July 1, 2016 10:08
@maflcko
Copy link
Member Author

maflcko commented Jul 1, 2016

https://github.com/bitcoin/bitcoin/blob/master/src/indirectmap.h doesn't contain copyright header at all.

Somone would need to ask the author where it came from. Only they can chose the copyright...

roques
roques reviewed Jul 1, 2016
View reviewed changes
contrib/debian/examples/bitcoin.conf Outdated
Copy link
Contributor

@roques roques Jul 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit (BTC/kB) of paytxfee should be specified here, as it is in bitcoind -?.
I also would completely remove the second sentence.

Copy link
Member Author

@maflcko maflcko Jul 1, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maflcko maflcko force-pushed the Mf1607-trivialPre13 branch from fa8968f to fa380a8 Compare July 2, 2016 09:13
@maflcko
Copy link
Member Author

maflcko commented Jul 3, 2016

@paveljanik The script is not portable...

I changed something. It may or may not work now.

@maflcko maflcko force-pushed the Mf1607-trivialPre13 branch from fa380a8 to fade7e9 Compare July 8, 2016 08:57
@fanquake fanquake mentioned this pull request Jul 12, 2016
Closed
@sipa
Copy link
Member

sipa commented Jul 12, 2016 •
edited
Loading

@kazcw wrote indirectmap

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jul 12, 2016

ACK everything except copyright bumps.

Agree with @paveljanik

@maflcko
Copy link
Member Author

maflcko commented Jul 12, 2016 via email

@paveljanik
Copy link
Contributor

paveljanik commented Jul 12, 2016

@MarcoFalke Sure, I will try to do it this week.

@paveljanik
Copy link
Contributor

paveljanik commented Jul 12, 2016

ACK fade7e9

Fixed script contrib/devtools/fix-copyright-headers.py now works even on OS X. Thanks!

@kazcw kazcw mentioned this pull request Jul 27, 2016
Merged
fanquake
fanquake reviewed Aug 8, 2016
View reviewed changes
qa/pull-tester/rpc-tests.py Outdated
Copy link
Member

@fanquake fanquake Aug 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove this line?

Copy link
Member Author

@maflcko maflcko Aug 8, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maflcko maflcko force-pushed the Mf1607-trivialPre13 branch 4 times, most recently from fad76c1 to faa2acb Compare August 22, 2016 08:53
@maflcko maflcko changed the title [doc] typos, READMEs, comments, headers [contrib] conf: Remove sendfreetransactions (debug option) Aug 28, 2016
@maflcko maflcko changed the title [contrib] conf: Remove sendfreetransactions (debug option) [doc] Docs and copyright headers bump Aug 28, 2016
@maflcko maflcko force-pushed the Mf1607-trivialPre13 branch from faa2acb to 6f82c2d Compare September 20, 2016 20:43
@maflcko maflcko force-pushed the Mf1607-trivialPre13 branch from 6f82c2d to 2a064e5 Compare September 20, 2016 21:00
@maflcko maflcko closed this Sep 20, 2016
@maflcko maflcko deleted the Mf1607-trivialPre13 branch September 20, 2016 21:03
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maflcko @paveljanik @sipa @jonasschnelli @roques @fanquake