Merged
Conversation
qa/rpc-tests/wallet-hd.py
Outdated
Contributor
There was a problem hiding this comment.
This won't trigger a rescan. It should be self.node_args[1] + ['-rescan'].
self.node_args[1].extend(['-rescan']) results in null?.
Member
Author
There was a problem hiding this comment.
Awesome! It is always good to have fresh eyes look on the code.
Will push a fix and then squash the commits.
Contributor
|
Thanks for the test! |
Member
|
Thanks for the test @MarcoFalke and thanks for investigating the issue so quickly during the meeting yesterday @jonasschnelli |
laanwj
added a commit
that referenced
this pull request
Jul 8, 2016
str4d
pushed a commit
to str4d/zcash
that referenced
this pull request
Mar 24, 2020
Zcash: Excludes wallet-hd.py change (missing bitcoin/bitcoin#8309)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 24, 2020
Backport RPC test harness PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6548 - bitcoin/bitcoin#6804 - Just the coverage backend, not the flag to enable it. - bitcoin/bitcoin#7744 - bitcoin/bitcoin#9832 - Excludes `wallet-hd.py` change (missing bitcoin/bitcoin#8309). Part of #2074.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 3, 2020
Backport RPC test harness PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6548 - bitcoin/bitcoin#6804 - Just the coverage backend, not the flag to enable it for all RPC tests. - bitcoin/bitcoin#7744 - bitcoin/bitcoin#9832 - Excludes `wallet-hd.py` change (missing bitcoin/bitcoin#8309). Part of #2074.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.