Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock#8413
Merged
sipa merged 1 commit intobitcoin:masterfrom Jul 31, 2016
Merged
Conversation
jtimon
force-pushed
the
0.13-consensus-last-params
branch
from
c238a55 to
c8664ee
Compare
Contributor
Author
|
Sorry, contained an old TODO that wasn't true. Updated. Ping @NicolasDorier @dcousens |
15 tasks
Contributor
|
utACK c8664ee |
Contributor
|
utACK c8664ee |
Member
|
utACK c8664ee |
Contributor
|
utACK c8664ee |
Contributor
|
utACK c8664ee |
sipa
added a commit
that referenced
this pull request
Jul 31, 2016
…& in ContextualCheckBlock c8664ee Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock (Jorge Timón)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 8, 2018
…nParams& in ContextualCheckBlock c8664ee Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock (Jorge Timón)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…nParams& in ContextualCheckBlock c8664ee Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock (Jorge Timón)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-witness my plan was to get rid of ContextualCheckBlock and move its check to ConnectBlock/Consensus::VerifyTx, so this was not necessary.
This should be the last existing consensus function that needs to get Consensus::Params instead of ChainParams or call Params() from inside.