Merged
Conversation
Member
|
utACK fa4439d |
laanwj
added a commit
that referenced
this pull request
Aug 3, 2016
fa4439d [qa] Rework hd wallet dump test (MarcoFalke)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8442 Rebased-From: fa4439d
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Feb 1, 2018
fa4439d [qa] Rework hd wallet dump test (MarcoFalke)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
fa4439d [qa] Rework hd wallet dump test (MarcoFalke)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
fa4439d [qa] Rework hd wallet dump test (MarcoFalke)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes my nits from #8417... The largest chunk is moving most of the code into
read_dump, to get rid of the duplicated code.