Skip to content

Fix a type error that would not compile on OSX.#8513

Merged
laanwj merged 1 commit intobitcoin:masterfrom
JeremyRubin:fix-osx-break
Aug 17, 2016
Merged

Fix a type error that would not compile on OSX.#8513
laanwj merged 1 commit intobitcoin:masterfrom
JeremyRubin:fix-osx-break

Conversation

@JeremyRubin
Copy link
Contributor

@JeremyRubin JeremyRubin commented Aug 15, 2016

I was unable to compile on OSX without having the proper type here.

@paveljanik
Copy link
Contributor

paveljanik commented Aug 15, 2016

@JeremyRubin can you please paste exact error message?

@JeremyRubin
Copy link
Contributor Author

JeremyRubin commented Aug 16, 2016 

httprpc.cpp:234:5: error: no matching function for call to 'RegisterHTTPHandler'
    RegisterHTTPHandler("/", true, HTTPReq_JSONRPC);
    ^~~~~~~~~~~~~~~~~~~
./httpserver.h:41:6: note: candidate function not viable: no known conversion from 'bool (HTTPRequest *, const std::string &)' to 'const HTTPRequestHandler'
      (aka 'const function<void (HTTPRequest *, const std::string &)>') for 3rd argument
void RegisterHTTPHandler(const std::string &prefix, bool exactMatch, const HTTPRequestHandler &handler);
     ^
1 error generated.
make[1]: *** [libbitcoin_server_a-httprpc.o] Error 1
make: *** [all-recursive] Error 1

@paveljanik
Copy link
Contributor

paveljanik commented Aug 16, 2016

Interesting. Can't reproduce here, but the change is obviously correct.

ACK 8194a6e

@JeremyRubin
Copy link
Contributor Author

JeremyRubin commented Aug 17, 2016

@paveljanik

you have:

Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.5.0
Thread model: posix

on master?

@paveljanik
Copy link
Contributor

paveljanik commented Aug 17, 2016

My clang is:

Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin14.5.0
Thread model: posix

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Aug 17, 2016

Can't reproduce either, but utACK.

Apple LLVM version 7.3.0 (clang-703.0.31)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@laanwj
Copy link
Member

laanwj commented Aug 17, 2016

This is safe: all functions that are registered with RegisterHTTPHandler return a bool.
ACK 8194a6e

@laanwj laanwj merged commit 8194a6e into bitcoin:master Aug 17, 2016
laanwj added a commit that referenced this pull request Aug 17, 2016
@laanwj
Merge #8513: Fix a type error that would not compile on OSX.
65e6444 
8194a6e Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) (Jeremy Rubin)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016
@JeremyRubin @luke-jr
Fix a type error that would not compile on Apple LLVM version 6.1.0 (…
4e5fc31 
…clang-602.0.53) (based on LLVM 3.6.0svn)

Github-Pull: bitcoin#8513
Rebased-From: 8194a6e
codablock pushed a commit to codablock/dash that referenced this pull request Jan 8, 2018
@laanwj @codablock
Merge bitcoin#8513: Fix a type error that would not compile on OSX.
6b8160b 
8194a6e Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) (Jeremy Rubin)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#8513: Fix a type error that would not compile on OSX.
8ff3001 
8194a6e Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) (Jeremy Rubin)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

macOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JeremyRubin @paveljanik @jonasschnelli @laanwj