Update p2p-segwit.py to reflect correct behavior#8528
Merged
laanwj merged 2 commits intobitcoin:masterfrom Sep 13, 2016
Merged
Conversation
qa/rpc-tests/p2p-segwit.py
Outdated
Member
There was a problem hiding this comment.
Ah, this code could be commented better I think. I did intend for the transaction to be too large for standardness rules, to ensure that we were checking for premature witness before doing the IsStandard check (that change was a recent bugfix). Perhaps just improve the comment, rather than change the test itself?
Member
Author
There was a problem hiding this comment.
I'm not exactly clear what you were shooting for, so feel free to suggest new text?
Member
There was a problem hiding this comment.
What do you think of this:
# We'll add an unnecessary witness to this transaction that would cause
# it to be non-standard, to test that violating policy with a witness before
# segwit activation doesn't blind a node to a transaction. Transactions
# rejected for having a witness before segwit activation shouldn't be added
# to the rejection cache.
And then at line 312, add a comment:
# Note that this should be rejected for the premature witness reason,
# rather than a policy check, since segwit hasn't activated yet.
Member
|
utACK |
Contributor
|
utACK 5547aeb |
1 similar comment
Member
|
utACK 5547aeb |
laanwj
added a commit
that referenced
this pull request
Sep 13, 2016
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8528 Rebased-From: bc1d1f2
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8528 Rebased-From: 5547aeb
Member
|
This is backported in #8772, removing needs-backport tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.