Merged
Conversation
Member
|
utACK |
Contributor
|
ACK |
Member
|
ACK c40b034 |
Contributor
|
ACK c40b034 |
laanwj
added a commit
that referenced
this pull request
Sep 9, 2016
c40b034 Clear witness with vin/vout in CWallet::CreateTransaction() (Suhas Daftuar)
Contributor
|
ACK c40b034 |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8664 Rebased-From: c40b034
Member
|
Backported in #8772, removing tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @jl2012.
When we clear out the
vinandvoutinCWallet::CreateTransaction(), we also need to clear out the witness, or else the witness might have extra entries that trigger this assertion failure:Please tag for 0.13.1.