Conversation
|
Ack from me |
|
permanent ACK on all code I contribute to this repository having the preferred copyright of the project |
|
ack from me |
|
ACK |
|
ACK 2229ffa |
|
ack |
|
ACK 2229ffa5e2b8e38cd962c02e2fc892e0c925675b |
|
utACK 2229ffa5e2b8e38cd962c02e2fc892e0c925675b Could make sense to explicitly add a section to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#contributing-to-bitcoin-core that says that every contribution must be MIT licensed by its author prior to creating a pull request. |
|
ACK 2229ffa |
|
ACK 2229ffa5e2b8e38cd962c02e2fc892e0c925675b |
|
Thanks everyone! We have ACK quorum on: contrib/devtools/optimize-pngs.py Still waiting on: contrib/zmq/zmq_sub.py (@jgarzik) I will give it a couple more days and then split the remaining files into a different PR so the ACKed ones can go in. |
|
Add the copyright to https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-build.sh please. I'll ACK it. |
isle2983
force-pushed
the
missing-copyright
branch
from
2229ffa to
dffe727
Compare
|
@achow101 copyright headers gitian-buiild.sh added in dffe727b259d0cc564e86aa1c33e7285e0f8c5b0 ...which reminds me that I should do another PR for *.sh files. |
|
ACK dffe727 |
|
ACK |
isle2983
force-pushed
the
missing-copyright
branch
2 times, most recently
from
058d56a to
783e930
Compare
|
783e930 drops the addition of the MIT headers in these files due to missing ACKs listed here: contrib/zmq/zmq_sub.py (@jgarzik) I will re-submit those as different PRs. @achow101 still owes the ACK promised above for gitian-build.sh. Assuming that comes, I submit that this PR is ready given the ACKs in #7300 and the present thread above. To recap, those were: contrib/devtools/optimize-pngs.py (@MarcoFalke, @jonasschnelli, @laanwj) |
|
ACK (I thought my ACK was implied by my statement) |
|
I think this is ready ACK dffe727 |
783e930 [copyright] Add missing copyright headers (isle2983)
Github-Pull: bitcoin#8676 Rebased-From: 783e930
783e930 [copyright] Add missing copyright headers (isle2983)
Github-Pull: bitcoin#8676 Rebased-From: 783e930
783e930 [copyright] Add missing copyright headers (isle2983)
15 participants
Adds 'The Bitcoin Core developers' copyright headers in 12 source files.
<start_year>-<end_year> is as per the history obtained from 'git log'.
The users to have touched them in the past are listed below. This was last
discussed in pull request #7300:
In that discussion I can see perma-ACKs from @MarcoFalke, @gavinandresen and
@laanwj.
So that leaves ACKs needed from:
@sipa
@jgarzik
@luke-jr
@theuni
@ChoHag
@calebogden
@mrbandrews
@casey
@MitchellCash
@brandondahler
Phillip Kaufmann
Broken down by file:
contrib/devtools/optimize-pngs.py (@MarcoFalke, @jonasschnelli, @laanwj)
contrib/devtools/security-check.py (@ChoHag, @laanwj, @theuni, @calebogden)
contrib/devtools/test-security-check.py (@ChoHag, @laanwj)
contrib/qt_translations.py (@gavinandresen)
contrib/seeds/makeseeds.py (@laanwj, @sipa, @gavinandresen)
contrib/spendfrom/setup.py (@gavinandresen)
contrib/spendfrom/spendfrom.py (@gavinandresen)
contrib/testgen/base58.py (@laanwj)
contrib/testgen/gen_base58_test_vectors.py (@laanwj)
contrib/zmq/zmq_sub.py (@jonasschnelli, @jgarzik)
qa/rpc-tests/test_framework/blockstore.py (@mrbandrews, @MarcoFalke, @casey, @jonasschnelli)
share/qt/extract_strings_qt.py (@ChoHag, @MitchellCash, @laanwj, @luke-jr, @brandondahler, Phillip Kaufmann, @theuni)