bitcoind: Daemonize using daemon(3) by laanwj · Pull Request #8813 · bitcoin/bitcoin

laanwj · 2016-09-26T09:39:00Z

Simplified version of #8278. Assumes that every OS that (a) is supported by Bitcoin Core (b) supports daemonization has the daemon() function in its C library.

Removes the fallback path for operating systems that support daemonization but not daemon(). This prevents never-exercised code from ending up in the repository (see discussion here:
Forking daemon #8278 (comment)).
Removes the windows-specific path. Windows doesn't support daemon(), so it doesn't support daemonization there, automatically. Give an explicit error if a user specifies -daemon on an OS where this is not supported.
Also made showing the help message depend on HAVE_DECL_DAEMON instead of !WIN32.

The original problem reported in #8278 was "When started with cron, the sendmail process hung around waiting for its stdin, bitcoind's stdout/err, to close..".

sipa · 2016-09-26T09:44:31Z

src/bitcoind.cpp

That's not true anymore.

Two more lines that can be deleted, thanks.

Simplified version of bitcoin#8278. Assumes that every OS that (a) is supported by Bitcoin Core (b) supports daemonization has the `daemon()` function in its C library. - Removes the fallback path for operating systems that support daemonization but not `daemon()`. This prevents never-exercised code from ending up in the repository (see discussion here: bitcoin#8278 (comment)). - Removes the windows-specific path. Windows doesn't support `daemon()`, so it don't support daemonization there, automatically. Original code by Matthew King, adapted by Wladimir van der Laan.

jonasschnelli

utACK a92bf4a (-comment nit mentioned by @sipa)

jonasschnelli · 2016-09-26T14:10:00Z

Tested ACK (OSX) a92bf4a.
Binaries: https://bitcoin.jonasschnelli.ch/pulls/8813/

maflcko · 2016-09-27T20:22:20Z

Possibly related: #4676 (haven't checked)

sipa · 2016-09-28T00:20:26Z

Concept ACK.

laanwj · 2016-09-28T07:18:03Z

Possibly related: #4676 (haven't checked)

Yes, using daemonize() seems quite a step closer to standard UNIX daemon practices. Though we had to decide in #8278 to use the nochdir flag as, without further changes, it would have effects on option behavior.

a92bf4a bitcoind: Daemonize using daemon(3) (Matthew King)

laanwj · 2016-09-30T16:21:07Z

Note: if you end up here seeing the "Error: -daemon is not supported on this operating system" message while your OS does support it, this most likely means you need to re-run autogen.sh and configure.

paveljanik · 2016-10-21T20:59:34Z

This brings new warning on OS X:

bitcoind.cpp:137:17: warning: 'daemon' is deprecated: first deprecated in OS X 10.5 [-Wdeprecated-declarations]
            if (daemon(1, 0)) {
                ^
/usr/include/stdlib.h:267:5: note: 'daemon' has been explicitly marked deprecated here
int daemon(int, int) __asm("_" "daemon" "$1050") __attribute__((availability(macosx,introduced=10.0,deprecated=10.5)));
    ^
1 warning generated.

laanwj · 2016-10-22T07:27:02Z

You can't be friggin serious.
I'm going to revert this - it's only causing trouble.

laanwj · 2016-10-22T07:27:58Z

@paveljanik Just curious do they suggest anything to use instead of daemon?

jonasschnelli · 2016-10-22T07:43:11Z

I wouldn't take the deprecation warning to serious.
OSX want devs to use its own launchd/launchctrl.
Removing the actual daemon() systemcall would break tons of applications and if - we would have at least 1-2 years to switch to launchd on OSX.

laanwj · 2016-10-22T07:43:23Z

Apparently they recommend doing something Apple-specific with plists and such https://developer.apple.com/library/content/technotes/tn2083/_index.html#//%20apple_ref/doc/uid/DTS10003794-CH1-SUBSECTION64
Bah. Okay, reverting this isn't any help either then. Never mind that. I got upset.

paveljanik · 2016-10-22T08:15:26Z

I agree with @jonasschnelli. No need to revert this. This only shows how Apple deprecates stuff.
10.5. Deprecated since October 26, 2007, still works now ;-)

What is the current status of daemon in the current macOS?

Simplified version of bitcoin#8278. Assumes that every OS that (a) is supported by Bitcoin Core (b) supports daemonization has the `daemon()` function in its C library. - Removes the fallback path for operating systems that support daemonization but not `daemon()`. This prevents never-exercised code from ending up in the repository (see discussion here: bitcoin#8278 (comment)). - Removes the windows-specific path. Windows doesn't support `daemon()`, so it don't support daemonization there, automatically. Original code by Matthew King, adapted by Wladimir van der Laan. Github-Pull: bitcoin#8813 Rebased-From: a92bf4a

a92bf4a bitcoind: Daemonize using daemon(3) (Matthew King)

laanwj added the Utils/log/libs label Sep 26, 2016

laanwj mentioned this pull request Sep 26, 2016

Forking daemon #8278

Closed

sipa reviewed Sep 26, 2016

View reviewed changes

laanwj force-pushed the 2016_09_daemonize branch 3 times, most recently from a7ca7c8 to dbd66f1 Compare September 26, 2016 10:17

laanwj changed the title ~~bitcoind: Daemonise using daemon(3)~~ bitcoind: Daemonize using daemon(3) Sep 26, 2016

laanwj force-pushed the 2016_09_daemonize branch from dbd66f1 to a92bf4a Compare September 26, 2016 11:38

jonasschnelli approved these changes Sep 26, 2016

View reviewed changes

laanwj merged commit a92bf4a into bitcoin:master Sep 30, 2016

laanwj added a commit that referenced this pull request Sep 30, 2016

Merge #8813: bitcoind: Daemonize using daemon(3)

fb24d7e

a92bf4a bitcoind: Daemonize using daemon(3) (Matthew King)

laanwj mentioned this pull request Oct 24, 2016

OS-specific background service for bitcoind #9005

Closed

laanwj mentioned this pull request Dec 6, 2016

Suppress some annoying deprecation warnings (OSX) #9284

Closed

sipa mentioned this pull request Mar 31, 2017

bitcoind ignores -printtoconsole flag #10132

Closed

codablock pushed a commit to codablock/dash that referenced this pull request Jan 12, 2018

Merge bitcoin#8813: bitcoind: Daemonize using daemon(3)

210242e

a92bf4a bitcoind: Daemonize using daemon(3) (Matthew King)

Sjors mentioned this pull request Mar 16, 2018

Follow standard Unix daemon practices #4676

Closed

Empact mentioned this pull request Apr 11, 2018

[Trivial] Ignore macOS daemon() depracation warning #12941

Merged

andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019

Merge bitcoin#8813: bitcoind: Daemonize using daemon(3)

88c4a0a

a92bf4a bitcoind: Daemonize using daemon(3) (Matthew King)

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Conversation

laanwj commented Sep 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sipa Sep 26, 2016

Choose a reason for hiding this comment

Uh oh!

laanwj Sep 26, 2016

Choose a reason for hiding this comment

Uh oh!

jonasschnelli left a comment

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Sep 26, 2016

Uh oh!

maflcko commented Sep 27, 2016

Uh oh!

sipa commented Sep 28, 2016

Uh oh!

laanwj commented Sep 28, 2016

Uh oh!

laanwj commented Sep 30, 2016

Uh oh!

paveljanik commented Oct 21, 2016

Uh oh!

laanwj commented Oct 22, 2016

Uh oh!

laanwj commented Oct 22, 2016

Uh oh!

jonasschnelli commented Oct 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Oct 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paveljanik commented Oct 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

laanwj commented Sep 26, 2016 •

edited

Loading

jonasschnelli commented Oct 22, 2016 •

edited

Loading

laanwj commented Oct 22, 2016 •

edited

Loading