Log entries that change their format are really bad for tooling. Is there any reason why it's bad to log limits that are at their maximum because they're not being applied?

The current code is not logging nBlockSize at its maximum when size is not being accounted. Under the current code, when a block is being created, the following happens:

• set nBlockSize to 1000 (bytes) to reserve space for the coinbase transaction
• set nBlockWeight to 4000 to reserve space for the coinbase transaction
• for every transaction that is added to the block:
  • if size is being accounted update nBlockSize
  • update nBlockWeight
• when the block is complete, log nBlockSize and not nBlockWeight

That means that if size is not being accounted, CreateNewBlock always logs that a block of size 1000 (bytes) has been created.

I don't think we should just change the log to output size = 1000000 if size isn't being accounted.

I propose the following change:

• add nBlockWeight to the log
• if size is being accounted, both size and weight will be logged correctly
• if size is not being accounted, set size to 0 and log weight correctly.

Maybe @gmaxwell's concern can be addressed by logging 'total size ?'

Alternatively, you can always just compute the total block size using ::GetSerializeSize(block, SER_NETWORK, PROTOCOL_VERSION).

Updated to always calculate size and weight correctly (whether or not size is being accounted). I'll update the description of this PR.

utACK

@laanwj - this PR fixes a bug where bitcoin logs incorrect sizes for new blocks. Is there anything I can do to help this get merged?

Backported in #9264, removing tag.