Make GetFetchFlags always request witness objects from witness peers#8871
Closed
TheBlueMatt wants to merge 2 commits intobitcoin:masterfrom
Closed
Make GetFetchFlags always request witness objects from witness peers#8871TheBlueMatt wants to merge 2 commits intobitcoin:masterfrom
TheBlueMatt wants to merge 2 commits intobitcoin:masterfrom
Conversation
This fixes a bug where we might (in exceedingly rare circumstances) accidentally ban a node for sending us the first (potentially few) segwit blocks in non-segwit mode.
TheBlueMatt
force-pushed
the
fetchflags
branch
from
89797ca to
2da86f9
Compare
TheBlueMatt
force-pushed
the
fetchflags
branch
from
e9b1e6a to
84a32a8
Compare
Member
|
ACK |
Contributor
|
utACK 84a32a8 |
Contributor
|
might be worth dropping the pprev parameter completely? |
Contributor
Author
|
This late in 13.1, I wanted to touch as little code as possible. I'd call that a candidate for cleanup in 14. On October 7, 2016 5:45:50 PM GMT+02:00, Nicolas Dorier [email protected] wrote:
|
Contributor
|
@TheBlueMatt is this for backport? |
Contributor
Author
Member
|
I guess this will be backported through #8393 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where we might (in exceedingly rare circumstances)
accidentally ban a node for sending us the first (potentially few)
segwit blocks in non-segwit mode.
See #8393 (comment) for the compact-block-related issue, though there is a similar(ly rare) version in ::INV processing as well.