Enable pubkey lookup for p2sh-p2wpkh in validateaddress#8992
Closed
instagibbs wants to merge 2 commits intobitcoin:masterfrom
Closed
Enable pubkey lookup for p2sh-p2wpkh in validateaddress#8992instagibbs wants to merge 2 commits intobitcoin:masterfrom
instagibbs wants to merge 2 commits intobitcoin:masterfrom
Conversation
jl2012
reviewed
Oct 21, 2016
src/rpc/misc.cpp
Outdated
| CPubKey vchPubKey; | ||
| if (pwalletMain->GetPubKey(CKeyID(uint160(witnessprogram)), vchPubKey)) { | ||
| obj.push_back(Pair("pubkey", HexStr(vchPubKey))); | ||
| obj.push_back(Pair("iscompressed", vchPubKey.IsCompressed())); |
Contributor
There was a problem hiding this comment.
Signing and watching with segwit uncompressed keys are already disabled. I think the results should be suppressed if the key is not compressed.
Member
Author
|
@jl2012 suppressed uncompressed pubkeys and removed the |
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 21, 2016
Github-Pull: bitcoin#8992 Rebased-From: 3d2db70
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 21, 2016
Github-Pull: bitcoin#8992 Rebased-From: 981af93
Member
Author
|
Closing in favor of #9017 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we ever switch to p2sh-p2pkh this will be useful for general wallet usage, as well as adapting tests where retrieving the pubkeys for standard addresses is important.