Trivial: Explicitly pass const CChainParams& to LoadBlockIndexDB()#9013
Trivial: Explicitly pass const CChainParams& to LoadBlockIndexDB()#9013laanwj merged 1 commit intobitcoin:masterfrom
Conversation
|
Hi @gtsui welcome to the project! utACK (stands for "untested ACK", see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review ) The only thing that I have to add is that there was some recent talk about replacing the checkpoints as a mechanism for guessing the verification progress. If that change were made, then LoadBlockIndexDB() and LoadBlockIndex() could take only a const Consensus::Params& instead of the full const CChainParams&. |
|
utACK d0b01f3 Sure, in the future this could probably be reduced in scope to a ConsensusParams, but passing the entire chainparams doesn't hurt and changing the parameter would be a low-priority change afterward. |
|
utACK d0b01f3 |
| bool static LoadBlockIndexDB() | ||
| bool static LoadBlockIndexDB(const CChainParams& chainparams) | ||
| { | ||
| const CChainParams& chainparams = Params(); |
There was a problem hiding this comment.
…kIndexDB() d0b01f3 Explicitly pass const CChainParams& to LoadBlockIndexDB() (Geoffrey Tsui)
…oadBlockIndexDB() d0b01f3 Explicitly pass const CChainParams& to LoadBlockIndexDB() (Geoffrey Tsui)
…oadBlockIndexDB() d0b01f3 Explicitly pass const CChainParams& to LoadBlockIndexDB() (Geoffrey Tsui)
…oadBlockIndexDB() d0b01f3 Explicitly pass const CChainParams& to LoadBlockIndexDB() (Geoffrey Tsui)
…oadBlockIndexDB() d0b01f3 Explicitly pass const CChainParams& to LoadBlockIndexDB() (Geoffrey Tsui)
6 participants
This is a continuation of #7829 by @jtimon
Explicitly pass CChainParams& to LoadBlockIndexDB() and LoadBlockIndex() and removed the Params() global call