Moving the CheckBlock in ConnectBlock seems to cause p2p-compactblocks.py to stall out when run in batch. Perhaps seeing patterns that do not exist.

tested ACK 6e18ae4

EDIT: walletbackup.py doesn't really pass locally, only when I run it individually, the failure seems to start at 50e8a9c

EDIT2: I would test ACK master...jtimon:0.13-instagibbs-dontvalidategenesis though (based on e984730 works for me)

I wonder how many times we've purportedly fixed this.

Can you please add a test to make sure that the genesis block is really, really not validated and to prevent this from regressing again?

@laanwj Until we have a method of loading up our own test networks via json/whatever I'm not sure how to test this. We need to create an invalid genesis block and has it pass, right?

@laanwj You may be remembering some of my previous attempts at doing this (like #6597 or #6230 ), but they didn't get merged. It is true that the only way to make sure it is and remains complete is to test it though.
But I'm afraid the only way to test this is from rpc and with a new chain whose genesis block is actually invalid (and not only in pow but other things like bip34).
We could more easily write such a test with something like #8994 which contains this and other things to make testchains more easily.

Needs rebase.

rebased

As a reminder, #8994 tests this commit with all python tests except for p2p-segwit.py and p2p-compactblocks.py.
@laanwj would that be sufficient testing?
Is there a simpler way to test it and have tests that prevent this from breaking again than create a new regtest-like testchain whose genesis block doesn't satisfy pow?

Closing as it needs tests, and #8994 provides those, so they should be packaged together.