bug: Missed one "return false" in recent refactoring in #9067#9120
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 10, 2016
UdjinM6:fixExitCodesBitcoinTx
Merged
bug: Missed one "return false" in recent refactoring in #9067#9120laanwj merged 1 commit intobitcoin:masterfrom UdjinM6:fixExitCodesBitcoinTx
laanwj merged 1 commit intobitcoin:masterfrom
UdjinM6:fixExitCodesBitcoinTx
Conversation
Contributor
|
Thanks for fixing this up. |
Member
|
utACK 45d372f |
Contributor
|
ACK 45d372f |
Member
|
If only we had a test for this :) |
laanwj
added a commit
that referenced
this pull request
Nov 10, 2016
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Dec 2, 2016
Github-Pull: bitcoin#9120 Rebased-From: 45d372f
sickpig
referenced
this pull request
in sickpig/BitcoinUnlimited
Mar 31, 2017
…#9067 45d372f Missed one "return false" in recent refactoring in #9067 (UdjinM6)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 16, 2018
Github-Pull: bitcoin#9120 Rebased-From: 45d372f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed one "return false" in recent refactoring in #9067 which means that
AppInitRawTxreturns0in that case i.e. EXIT_SUCCESS which is wrong.Sorry 😞