Skip to content

Initialize variable to prevent compiler warning#9121

Merged
laanwj merged 1 commit intobitcoin:masterfrom
paveljanik:20161110_rpcdump_uninitialized
Nov 10, 2016
Merged

Initialize variable to prevent compiler warning#9121
laanwj merged 1 commit intobitcoin:masterfrom
paveljanik:20161110_rpcdump_uninitialized

Conversation

@paveljanik
Copy link
Contributor

@paveljanik paveljanik commented Nov 10, 2016

Compiling current master with the ultimate gcc 6 (6.2.1 in my case) brings this warning. While technically useless it can hide important stuff.

  CXX      wallet/libbitcoin_wallet_a-rpcdump.o
wallet/rpcdump.cpp: In function 'UniValue importmulti(const JSONRPCRequest&)':
wallet/rpcdump.cpp:1020:13: warning: 'nLowestTimestamp' may be used uninitialized in this function [-Wmaybe-uninitialized]
     int64_t nLowestTimestamp;
             ^~~~~~~~~~~~~~~~

@sipa
Copy link
Member

sipa commented Nov 10, 2016

utACK bdcba6d

1 similar comment
@jonasschnelli
Copy link
Contributor

jonasschnelli commented Nov 10, 2016

utACK bdcba6d

@fanquake
Copy link
Member

fanquake commented Nov 10, 2016

utACK bdcba6d

@laanwj laanwj merged commit bdcba6d into bitcoin:master Nov 10, 2016
laanwj added a commit that referenced this pull request Nov 10, 2016
@laanwj
Merge #9121: Initialize variable to prevent compiler warning
aab102c 
bdcba6d Initialize variable to prevent compiler warning (Pavel Janík)
@ryanofsky ryanofsky mentioned this pull request Feb 2, 2017
Merged
codablock pushed a commit to codablock/dash that referenced this pull request Jan 15, 2018
@laanwj @codablock
Merge bitcoin#9121: Initialize variable to prevent compiler warning
5f69086 
bdcba6d Initialize variable to prevent compiler warning (Pavel Janík)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#9121: Initialize variable to prevent compiler warning
a4d43f1 
bdcba6d Initialize variable to prevent compiler warning (Pavel Janík)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 24, 2019
@laanwj @CryptoCentric
Merge bitcoin#9121: Initialize variable to prevent compiler warning
89c652c 
bdcba6d Initialize variable to prevent compiler warning (Pavel Janík)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dcousens dcousens dcousens approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@paveljanik @sipa @jonasschnelli @fanquake @dcousens @laanwj