Use better name for local variable to prevent -Wshadow compiler warning#9124
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 11, 2016
Merged
Conversation
laanwj
added a commit
that referenced
this pull request
Nov 11, 2016
…ompiler warning bf49f10 Use better name for local variable to prevent -Wshadow compiler warning (Pavel Janík)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 15, 2018
…hadow compiler warning bf49f10 Use better name for local variable to prevent -Wshadow compiler warning (Pavel Janík)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…hadow compiler warning bf49f10 Use better name for local variable to prevent -Wshadow compiler warning (Pavel Janík)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 24, 2019
…hadow compiler warning bf49f10 Use better name for local variable to prevent -Wshadow compiler warning (Pavel Janík)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9049 brought new
-Wshadowwarning.Local variable shadows the function argument. I decided to keep the function argument name to keep consistency with the rest of the file and use better/descriptive name for the local variable.