Unset fImporting for loading mempool#9133
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 16, 2016
Merged
Conversation
Member
|
utACK 79f755d |
dcousens
approved these changes
Nov 16, 2016
Contributor
|
utACK (I hesitated due to the lack of indent, but Sipa pointed out to me that we do it elsewhere.) |
laanwj
added a commit
that referenced
this pull request
Nov 16, 2016
79f755d Unset fImporting for loading mempool (Alex Morcos)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 15, 2018
79f755d Unset fImporting for loading mempool (Alex Morcos)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
79f755d Unset fImporting for loading mempool (Alex Morcos)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 24, 2019
79f755d Unset fImporting for loading mempool (Alex Morcos)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadMempool happens in the import thread which has fImporting set to true. This will cause the node to think its in IBD until the mempool is fully loaded. This isn't necessary and can interfere with initial syncing. It also breaks at least the pruning.py test.
I can't think of any reason to want IBD to be set while loading the mempool except for the possible effect on fee estimation. If you had a mempool dump which was in the future from your chainstate then this might lead to a detrimental effect on fee estimation, but this seems unlikely and should be fixed in another way..