Clarify CreateTransaction error messages#9204
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 23, 2016
Merged
Conversation
morcos
reviewed
Nov 22, 2016
src/wallet/wallet.cpp
Outdated
Contributor
There was a problem hiding this comment.
Do you want to include this line too?
Not sure it's worth changing these, but if you are going to, perhaps you could be even more clear
"One of the transaction output amounts .." or similar
Member
Author
There was a problem hiding this comment.
you're right not important, thought I changed it back
Member
|
utACK |
Member
|
utACK 918b126 |
Member
|
utACK 918b126 |
Contributor
|
trivial utACK 918b126 |
laanwj
added a commit
that referenced
this pull request
Nov 23, 2016
918b126 fix CreateTransaction error messages (instagibbs)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 15, 2018
918b126 fix CreateTransaction error messages (instagibbs)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
918b126 fix CreateTransaction error messages (instagibbs)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 24, 2019
918b126 fix CreateTransaction error messages (instagibbs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic change removing nValue check is fine since value won't be negative, and thus can give a better error.