Prevent FD_SETSIZE error building on OpenBSD#9224
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 29, 2016
Merged
Conversation
Contributor
|
Hardcoding it is wrong for systems other than windows. If it's missing on OpenBSD it may be necessary to add another header. select.h would be an obvious candidate. |
Member
|
FD_SETSIZE has historically been able to be overridden on most systems, but unfortunately IIRC some years ago glibc hard-coded it so it cannot be changed. :( |
Member
|
ACK after squash. Adding a header is the right thing to do. I wonder why you need this though, I have built many times on OpenBSD (https://github.com/bitcoin/bitcoin/blob/master/doc/build-openbsd.md) without stumbling on this issue. |
Contributor
Author
|
I started using OpenBSD again after some time. I upgraded to -current and followed the instructions in build-openbsd.md and got the error that FD_SETSIZE was undeclared. |
laanwj
force-pushed
the
unix-compilation
branch
from
0bea6fc to
498a1d7
Compare
laanwj
changed the title
laanwj
added a commit
that referenced
this pull request
Nov 29, 2016
498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Dec 2, 2016
Github-Pull: bitcoin#9224 Rebased-From: 498a1d7
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 17, 2018
498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 25, 2019
498a1d7 Include select.h when WIN32 is not defined (Ivo van der Sangen)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the build in cases WIN32 is not defined. At least on OpenBSD this made the build work.