Improvement of documentation of command line parameter 'whitelist'#9249
Conversation
I wonder what "netmask" one should give here. E.g. for 24 bit netmask give `whitelist=24` ? What use should that have? If I guess correctly, what is meant here is a network segment, not a netmask. So, e.g. I expect one can say `whitelist=1.2.3.0/24`
Contributor
|
ACK. |
Contributor
|
Nica catch, utACK 8a639e1 |
Member
|
Please just fix it upstream.
https://github.com/bitcoin/bitcoin/blob/40022fe5f2b576d023fa260eb176bde6d0779330/src/init.cpp#L394
We will take care to populate it downstream.
…On Wed, Nov 30, 2016 at 4:35 PM, paveljanik ***@***.***> wrote:
Nica catch, utACK 8a639e1
<8a639e1>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9249 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv7Sf5tcmoqAlLaUCt1HJASUNcChnks5rDZe-gaJpZM4LAUYf>
.
|
ghost
mentioned this pull request
Author
|
Sorry, I have made a mess. I don't know github so good. No I do not know anymore what to do.... :-/ https://github.com/wodry/bitcoin/commit/db04974eba6eb27816c0da5a3b1c5ecbedcf5978 was wrong because there was "given given" double word. |
Member
|
No worries, you can add commits as you like to fix mistakes, we can take
care of squashing later. (Also, please close one of the two pulls)
…On Wed, Nov 30, 2016 at 5:28 PM, wodry ***@***.***> wrote:
Sorry, I have made a mess. I don't know github so good. No I do not know
anymore what to do.... :-/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9249 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv9-ylVxQVEz3gOQDBcIGozoXXZHAks5rDaQxgaJpZM4LAUYf>
.
|
Author
|
Closed in favour of #9251 |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wonder what "netmask" one should give here. E.g. for 24 bit netmask give
whitelist=24? What use should that have?If I guess correctly, what is meant here is a network segment, not a netmask. So, e.g. I expect one can say
whitelist=1.2.3.0/24