[0.13 Backport] IBD using chainwork instead of height and not using header timestamp (#9053)#9293
Merged
laanwj merged 4 commits intobitcoin:0.13from Dec 8, 2016
gmaxwell:9053_backport
Merged
[0.13 Backport] IBD using chainwork instead of height and not using header timestamp (#9053)#9293laanwj merged 4 commits intobitcoin:0.13from gmaxwell:9053_backport
laanwj merged 4 commits intobitcoin:0.13from
gmaxwell:9053_backport
Conversation
Member
This introduces a 'minimum chain work' chainparam which is intended to be the known amount of work in the chain for the network at the time of software release. If you don't have this much work, you're not yet caught up. This is used instead of the count of blocks test from checkpoints. This criteria is trivial to keep updated as there is no element of subjectivity, trust, or position dependence to it. It is also a more reliable metric of sync status than a block count. Github-Pull: #9053 Rebased-From: fd46136
Contributor
Author
|
@MarcoFalke K. I believe I addressed your comments (I just imitated the style by hand.) |
Member
|
utACK 5998a09 |
Member
LGTM |
laanwj
added a commit
that referenced
this pull request
Dec 8, 2016
…d not using header timestamp (#9053) 5998a09 IsInitialBlockDownload no longer uses header-only timestamps. (Gregory Maxwell) 5b93eee Remove GetTotalBlocksEstimate and checkpoint tests that test nothing. (Gregory Maxwell) ad20cdd IBD check uses minimumchain work instead of checkpoints. (Gregory Maxwell) 4c71fc4 Remove duplicate nBlocksEstimate cmp (we already checked IsIBD()) (Matt Corallo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9053 -- we passed on backporting it right after it was merged, but it's been in master for over a month now with no issue.
This resolves some frequent annoying misbehavior on testnet (in theory the problems it solves are also possible on mainnet but aren't likely there without miner funny business).