[qa] Don't set unknown rpcserialversion#9322
Merged
laanwj merged 2 commits intobitcoin:masterfrom Dec 15, 2016
Merged
Conversation
Member
|
It looks intentional and desirable to allow setting future serialisation versions. Especially something like 9999 to mean "use the very latest even if not the default". |
Member
|
@luke-jr Makes sense, but I was assuming that's what the default was. |
Contributor
|
ACK |
laanwj
approved these changes
Dec 14, 2016
| if (GetArg("-rpcserialversion", DEFAULT_RPC_SERIALIZE_VERSION) < 0) | ||
| return InitError("rpcserialversion must be non-negative."); | ||
|
|
||
| if (GetArg("-rpcserialversion", DEFAULT_RPC_SERIALIZE_VERSION) > 1) |
Member
There was a problem hiding this comment.
Maybe define a constant for the max valid RPC serialize version?
Member
Author
There was a problem hiding this comment.
Which would imply the default is not always the max. It is not clear from the comments if this is desired.
Edit: Anyway, fixing this nit is irrelevant for backport. Either we merge/backport this and bikeshed later or we close the pull based on luke-jr's rationale.
laanwj
added a commit
that referenced
this pull request
Dec 15, 2016
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 15, 2016
Github-Pull: bitcoin#9322 Rebased-From: fa615d3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged, this will merge #9292 as well.
I created a new pull, so 0.13.2 isn't blocked by this.