[Qt] Console: allow empty arguments#9329
Merged
laanwj merged 3 commits intobitcoin:masterfrom Dec 19, 2016
Merged
Conversation
Member
|
Maybe add a unit test to check this case? |
Member
|
This doesn't appear to actually fix the problem at all: luke-jr@3710cf3 |
jonasschnelli
force-pushed
the
2016/12/fix_qt_empty_args
branch
from
147bd85 to
6a32c0f
Compare
Contributor
Author
|
Added @luke-jr's unit test, added some more fixes. |
Member
|
Here's a few more, including one that fails: RPCConsole::RPCExecuteCommandLine(result, "rpcNestedTest(abc,,abc)");
QVERIFY(result == "[\"abc\",\"\",\"abc\"]");
RPCConsole::RPCExecuteCommandLine(result, "rpcNestedTest(abc,,)"); // this one fails
QVERIFY(result == "[\"abc\",\"\",\"\"]");
RPCConsole::RPCExecuteCommandLine(result, "rpcNestedTest(abc )");
QVERIFY(result == "[\"abc\"]");
RPCConsole::RPCExecuteCommandLine(result, "rpcNestedTest( abc)");
QVERIFY(result == "[\"abc\"]"); |
Contributor
Author
|
Added more rules and tests.
|
Member
Makes sense, I think. |
laanwj
approved these changes
Dec 15, 2016
laanwj
added a commit
that referenced
this pull request
Dec 19, 2016
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 21, 2016
Github-Pull: bitcoin#9329 Rebased-From: 89c8d2c
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 21, 2016
Github-Pull: bitcoin#9329 Rebased-From: 6a32c0f
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 21, 2016
Github-Pull: bitcoin#9329 Rebased-From: 390bd14
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Aug 19, 2021
47607df [Qt] Console: don't allow empty arguments when using the comma-syntax (random-zebra) af215ef [Qt] Console: allow empty arguments (random-zebra) Pull request description: #2372 broke the support for empty arguments `""` (which is required as first argument of `sendmany`). Backport the fix from bitcoin#9329 Thanks to @NoobieDev12 for reporting this bug. ACKs for top commit: furszy: Nice catch👌, ACK 47607df Fuzzbawls: ACK 47607df Tree-SHA512: 9ebcce3fbcb10856fc0a586365a9f0c4a3bbed5df571f21b37a143a882ab937b0fdf0502d1ba39e015cc0f745b07ed78fa8eb547110d0e53401f0d88af89cba1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #9210 and re-allow empty arguments like
command '' <more arg...>orcommand "" <more args...>.