Closed
Conversation
dcousens
approved these changes
Dec 20, 2016
Contributor
|
Concept ACK |
Member
|
ACK |
dcousens
reviewed
Dec 20, 2016
src/wallet/wallet.cpp
Outdated
Contributor
There was a problem hiding this comment.
While understandably unused... this probably shouldn't be put under this commit
Member
Author
There was a problem hiding this comment.
Sure, I can squash all commits after we branch off 0.14 if you mean that.
Contributor
There was a problem hiding this comment.
@MarcoFalke I meant removing dead code in a commit titled as adding a warning is odd (unexpected).
How you rectify that, 2 commits, rebase, squash, whatever, I don't mind.
Member
Author
There was a problem hiding this comment.
Squashed. Sorry for the confusion.
This removes the option from the wallet to not pay a fee on "small" transactions which spend "old" inputs. This code is no longer worth keeping around, as almost all miners prefer not to include transactions which pay no fee at all.
maflcko
force-pushed
the
Mf1612-015walletSendFreeNONO
branch
from
fa060b2 to
fa7ddcc
Compare
Member
Author
|
Closing for now. This is meant for 0.15, which will land in fall 2017. No need to leave this open for months while merges are still happening for 0.14 on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull is a split-off of the large patch mentioned in #6675.
This removes the option from the wallet to not pay a fee on "small"
transactions which spend "old" inputs.
This code is no longer worth keeping around, as almost all miners
prefer not to include transactions which pay no fee at all.
Please note that it is still possible to create transaction which pay no fee at all through the raw transaction interface. Also, it is still possible to set the wallet transaction fee to any value of one satoshi or more.