Don't ask for TX relay from feeler connections#9403
Don't ask for TX relay from feeler connections#9403rebroad wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
Concept ACK on the relay suppression but I don't see a reason to reformat the sendmessage log entry. |
|
@gmaxwell it wasn't just a reformat, but now includes an indication whether relay is set true or false. |
|
I know, but the change can be made without reformatting it, other than adding the field or without reformatting it at all. When you reformat log entries it breaks parsing tools, which encourages serious operations to delay their upgrades. We should be a little more conservative in breaking log entries. Getpeerinfo already shows the state. |
|
@gmaxwell the change is "made without reformatting it, other than adding the field" - not sure what other reformatting you are referring to. I've looked at the code there times now and cannot see any reformatting, other than adding the field. |
|
Needs a rebase. |
|
Closing as no follow up. Please rebase & re-open when ready. |
3 participants
Although feeler connections are fairly brief (although not as brief as they used to be), we are not interested in receiving transactions from these connections therefore set relay to false when sending the version message.