Skip processing of TXs that we already have.#9414
Skip processing of TXs that we already have.#9414rebroad wants to merge 1 commit intobitcoin:masterfrom
Conversation
Previously TXs were processed more than they needed to be even though we already have them.
| EraseOrphanTx(hash); | ||
| } | ||
| } // if accepted to memory pool | ||
| else if (fMissingInputs) |
There was a problem hiding this comment.
for fMissingInputs to be true AlreadyHave() had to be false
| LogPrint("mempool", "not keeping orphan with rejected parents %s\n",tx.GetHash().ToString()); | ||
| } | ||
| } else { | ||
| } else { // not accepted and not missing inputs, i.e. invalid |
There was a problem hiding this comment.
whereas here AlreadyHave() could have been true still, so for whitelisted nodes, the same tx could be relayed multiple times
There was a problem hiding this comment.
That is the intended and advertised purpose of the whitelisting, read the comment in the else block!
|
&& is shortcutting so this doesn't change it to skip AcceptToMemoryPool. It does however change it so that it does not run the else clause which is needed for the forced relaying for whitelisted peers (which needs to run already for transactions we already have). So I think the only real behavior change this makes is to break the functionality. |
|
@gmaxwell Ah, yes, my apologies I has missed the whitelist intention there. It was primarily noticing that I am not aware yet of why we would want to relay txs (possibly multiple times) to whitelisted nodes that we already have in our mempool though - is this requirement documented somewhere please? |
2 participants
Previously TXs were processed more than they needed to be even though we already have them.