De-duplicate SignatureCacheHasher#9480
Merged
sipa merged 1 commit intobitcoin:masterfrom Apr 13, 2017
Merged
Conversation
Member
|
Everyone-loves-negative-net-diffs ACK 0b829c0 |
dcousens
approved these changes
Jan 6, 2017
Contributor
|
utACK 0b829c0 |
Contributor
|
ACK 0b829c0 |
Contributor
|
utACK |
Contributor
|
utACK but please don't mark this as trivial |
maflcko
changed the title
Contributor
|
utACK |
Contributor
|
utACK, checked moved/copied code is the same. |
JeremyRubin
force-pushed
the
refactor-signaturecachehasher-visibility
branch
from
0b829c0 to
99f45f7
Compare
Contributor
Author
|
I reworded the commit because I had accidentally used trivial in it originally. Code move not changed. |
Contributor
|
Needs rebase. |
JeremyRubin
force-pushed
the
refactor-signaturecachehasher-visibility
branch
from
99f45f7 to
4fe30d5
Compare
Contributor
Author
|
rebased |
Contributor
|
Please add an extra line between the commit title and the commit message, for some reason git likes to think that its all intended as a multi-line-super-long title if you dont. |
This moves the SignatureCacheHasher to the sigcache header, out of the anonymous namespace, so that the tests can import it.
JeremyRubin
force-pushed
the
refactor-signaturecachehasher-visibility
branch
from
4fe30d5 to
f9c8807
Compare
Contributor
Author
|
@TheBlueMatt I think that's a local issue in your git client settings, I can't reproduce it. Nonetheless, I inserted an additional newline. |
sipa
added a commit
that referenced
this pull request
Apr 13, 2017
f9c8807 Deduplicate SignatureCacheHasher (Jeremy Rubin) Tree-SHA512: 714a0f39d1c836fedd1868369b4ebf1096cd800cc544d57b54101da338c80c627a3e59c6644b3268054efe85053cf1a7be508af935f624491e7acfae61123994
Contributor
|
after-merge utACK f9c8807 |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 23, 2019
f9c8807 Deduplicate SignatureCacheHasher (Jeremy Rubin) Tree-SHA512: 714a0f39d1c836fedd1868369b4ebf1096cd800cc544d57b54101da338c80c627a3e59c6644b3268054efe85053cf1a7be508af935f624491e7acfae61123994
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Jul 3, 2020
2749d0a build: Include cuckoocache header in Makefile (furszy) 791a51f Deduplicate SignatureCacheHasher (Jeremy Rubin) 7a5918a Decrease testcase sizes in cuckoocache tests (Jeremy Rubin) 8ef3cc9 Trivial: fix comments referencing AppInit2 (Marko Bencun) f21b122 Ensure `-maxsigcachesize` is in valid range (John Newbery) 464b922 Add unit tests for the CuckooCache (Jeremy Rubin) 77e3b1e Add CuckooCache implementation and replace the sigcache map_type with it (Jeremy Rubin) Pull request description: Built on top of #1668. Part of the back port series to get us closer to upstream's sigcache current state. The main ones are: * bitcoin#8895 * bitcoin#9480 * bitcoin#9393 ACKs for top commit: random-zebra: Really nice backport. Tested ACK 2749d0a Fuzzbawls: utACK 2749d0a Tree-SHA512: 22f760edc928790f29a7bbd6e907a561b7ad266b6cc5e85f207206e0f39ae3e4328ec57c0be772c96036a15559b13f6956bea5762cace10f3a560090aeb6758b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, I duplicated the SignatureCacheHasher in the cuckoocache tests to avoid extra changes/review in the cuckoocache pr. This moves the SignatureCacheHasher to the sigcache header, out of the anonymous namespace, so that the tests can import it.
Not very critical, but it is good to make sure that these implementations don't ever diverge by only having this class defined once.