[net] Avoid initialization to a value that is never read#9539
Merged
laanwj merged 1 commit intobitcoin:masterfrom May 23, 2017
Merged
Conversation
dcousens
approved these changes
Jan 13, 2017
fanquake
changed the title
Contributor
Author
|
Replaced |
practicalswift
force-pushed
the
avoid-initialization-to-a-value-that-is-never-read
branch
from
327818d to
0ec6d14
Compare
TheBlueMatt
reviewed
Feb 7, 2017
src/netbase.cpp
Outdated
Contributor
There was a problem hiding this comment.
It looks like, in the case of non-STRERROR_R_CHAR_P, you'll get an error on the line below.
Contributor
Author
There was a problem hiding this comment.
@TheBlueMatt I'm not sure I follow. The intention is to keep the logic unchanged minus the redundant initialization. What am I missing? :-)
Contributor
There was a problem hiding this comment.
Ahh, somehow I missed the second line-addition, sorry.
Contributor
Author
|
Any changes needed before merge? :-) |
Contributor
|
In such cases, I personally prefer |
Prior to this commit the value stored to `s` at initialization was never read (in the case of STRERROR_R_CHAR_P).
practicalswift
force-pushed
the
avoid-initialization-to-a-value-that-is-never-read
branch
from
0ec6d14 to
5844609
Compare
Contributor
Author
|
@paveljanik Good point! Changed and pushed. Looks good? :-) |
Contributor
|
ACK 5844609 |
Contributor
Author
|
@laanwj Do you have any input with regards to this change? If I'm reading the history correctly I think you've touched this specific function :-) |
Member
|
utACK 5844609 |
laanwj
added a commit
that referenced
this pull request
May 23, 2017
5844609 [net] Avoid initialization to a value that is never read (practicalswift) Tree-SHA512: 068c3fba58034187f546688bc9b8b7317e0657e797850613fb6289a4efc28637e4d06a0fa5e57480538c6b8340ed6d6a6c6f9a96f130b698d5d60975490a03d8
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 24, 2019
…er read 5844609 [net] Avoid initialization to a value that is never read (practicalswift) Tree-SHA512: 068c3fba58034187f546688bc9b8b7317e0657e797850613fb6289a4efc28637e4d06a0fa5e57480538c6b8340ed6d6a6c6f9a96f130b698d5d60975490a03d8
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Dec 14, 2020
d46b369 [net] Avoid initialization to a value that is never read Prior to this commit the value stored to `s` at initialization was never read (in the case of STRERROR_R_CHAR_P). (furszy) f62d152 Revert "Use async name resolving to improve net thread responsiveness" (furszy) a1b0017 Use Socks5ErrorString() to decode error responses from socks proxy. (furszy) fdec2e3 Make Socks5() InterruptibleRecv() timeout/failures informative. Before: ERROR: Error reading proxy response (furszy) 2027d66 SOCKS5 connecting and connected messages with -debug=net. They were too noisy and not necessary for normal operation. (furszy) 097322c Make failures to connect via Socks5() more informative and less unnecessarily scary. * The "ERROR" was printed far too often during normal operation for what was not an error. (furszy) Pull request description: Made a set of back ports to make Socks5 connection failures less noisy and less unnecessarily scary. Plus added a straightforward removal of `getaddrinfo_a` which was never available at configure time. Back ported PRs list: bitcoin#8033 bitcoin#9229 bitcoin#9539 ACKs for top commit: Fuzzbawls: utACK d46b369 random-zebra: utACK d46b369 and merging... Tree-SHA512: 5b79309a2bc9ffca686e00b431d8205c72c353a56693b7f1e7a0a7245b158032e9243a49fea10a606cb2329726b3908fd5187ac6c8e57ddd0e9025a9811950ec
practicalswift
deleted the
avoid-initialization-to-a-value-that-is-never-read
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit the value stored to
sat initialization was never read (in the case ofSTRERROR_R_CHAR_P).