Merged
Conversation
morcos
force-pushed
the
removeMinReasonableFee
branch
from
b07419d to
ad82cb0
Compare
Contributor
Author
|
rebased |
Member
|
utACK ad82cb0. To help other reviewers: The mempool previously accepted an argument that appeared to be coming from the "-minrelaytxfee" option, but in reality (as @morcos said above) the CTxMempool had already been statically created with DEFAULT_MIN_RELAY_TX_FEE before the option was parsed: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L86 |
Member
|
ACK ad82cb0
|
Contributor
|
utACK ad82cb0. |
Contributor
|
utACK ad82cb0 |
laanwj
added a commit
that referenced
this pull request
Mar 7, 2017
ad82cb0 Remove unnecessary min fee argument in CTxMemPool constructor (Alex Morcos) 2a7b56c CBlockPolicyEstimator now uses hard coded minimum bucket feerate (Alex Morcos) ac9d3d2 Change fee estimation bucket limit variable names (Alex Morcos) Tree-SHA512: 6e3bc7df3497ed60c7620845d222063e33a0238020f5c3316e61e0eff758078588ea8dd51196ceb59aa561ba106f8cdae62cebe521adb3247108bb49f15252d6
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 5, 2019
ad82cb0 Remove unnecessary min fee argument in CTxMemPool constructor (Alex Morcos) 2a7b56c CBlockPolicyEstimator now uses hard coded minimum bucket feerate (Alex Morcos) ac9d3d2 Change fee estimation bucket limit variable names (Alex Morcos) Tree-SHA512: 6e3bc7df3497ed60c7620845d222063e33a0238020f5c3316e61e0eff758078588ea8dd51196ceb59aa561ba106f8cdae62cebe521adb3247108bb49f15252d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds off of #9380... It's just a cleanup PR and should be no change in functionality.
Previously the minReasonableRelayFee which was passed through CTxMempool to CBlockPolicyEstimator was just getting its statically initialized value of DEFAULT_MIN_RELAY_TX_FEE so this PR shortcuts passing it through for no reason.
It's perfectly fine to have a smaller min bucket feerate in fee estimation, it is just slightly less space efficient. However changing this number invalidates old fee estimate files.. So we change the hardcoded minimum rate to be the same rate that was being passed in previously (1000 from DEFAULT_MIN_RELAY_TX_FEE) and we can worry about changing it in the future if that ever becomes not small enough.
@theuni