[test] Avoid reading a potentially uninitialized variable in tx_invalid-test (transaction_tests.cpp)#9555
Merged
maflcko merged 1 commit intobitcoin:masterfrom Mar 7, 2017
Conversation
practicalswift
force-pushed
the
avoid-ub-in-tx_invalid-test
branch
from
0ed1087 to
dbb285a
Compare
Member
|
It is set one line before use, no?
…On Sat, Jan 14, 2017 at 8:45 PM, practicalswift ***@***.***> wrote:
Prior to this commit the err variable was not guaranteed to set prior to
the check ...
BOOST_CHECK_MESSAGE(err != SCRIPT_ERR_OK, ScriptErrorString(err));
... triggering UB.
------------------------------
You can view, comment on, or merge this pull request online at:
#9555
Commit Summary
- [test] Avoid undefined behaviour in tx_invalid-test
(transaction_tests.cpp)
File Changes
- *M* src/test/transaction_tests.cpp
<https://github.com/bitcoin/bitcoin/pull/9555/files#diff-0> (2)
Patch Links:
- https://github.com/bitcoin/bitcoin/pull/9555.patch
- https://github.com/bitcoin/bitcoin/pull/9555.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9555>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmvxdY6fMunnH-S0n2t9WF7XiZ_BQhks5rSSXkgaJpZM4LjuLa>
.
|
Contributor
Author
|
@MarcoFalke Not in the cases ...
... right? :-) |
Contributor
Author
|
@MarcoFalke After re-reading your comment I think that you might be referring to |
practicalswift
changed the title
practicalswift
force-pushed
the
avoid-ub-in-tx_invalid-test
branch
from
dbb285a to
6087290
Compare
practicalswift
changed the title
practicalswift
force-pushed
the
avoid-ub-in-tx_invalid-test
branch
2 times, most recently
from
e4c8db6 to
30e6c25
Compare
Member
|
It may be better to leave this be, so memory sanitizers and static analysis can detect cases where we fail to set it? |
practicalswift
force-pushed
the
avoid-ub-in-tx_invalid-test
branch
from
30e6c25 to
604228c
Compare
Contributor
Author
|
@luke-jr Good point about catching cases where we fail to set it. My suggestion is that we initialize to |
…id-test
Prior to this commit the err variable was not guaranteed to be set before
the check ...
BOOST_CHECK_MESSAGE(err != SCRIPT_ERR_OK, ScriptErrorString(err));
practicalswift
force-pushed
the
avoid-ub-in-tx_invalid-test
branch
from
604228c to
8455e36
Compare
Member
|
Indeed, I was reading the wrong lines of the file.
utACK 8455e36
|
Member
|
That will still suppress compiler and analyser warnings of using unassigned values. Is there a way we can initialise it, yet tell the compiler/etc to treat the value as uninitialised still? |
Contributor
Author
|
@luke-jr I don't know if that is possible and/or how to do it, but if possible I'll add such an annotation :-) Let me know if you find any info on how to achieve that |
Member
|
As long as the tests fail when the variable is not assigned the correct value in the code, all is fine. |
Contributor
Author
|
@MarcoFalke Yes, that should be the case now :-) |
maflcko
pushed a commit
that referenced
this pull request
Mar 7, 2017
…e in tx_invalid-test (transaction_tests.cpp) 8455e36 [test] Avoid reading a potentially uninitialized variable in tx_invalid-test (practicalswift) Tree-SHA512: 1064cdd5c9e4612a05397a5880535d93dbb18dec4897b4bbda9e6ad78d30f4c72303e4d23159398f1b33545ff5819e739e374d7cde757e402b26c355268a2319
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 5, 2019
…variable in tx_invalid-test (transaction_tests.cpp) 8455e36 [test] Avoid reading a potentially uninitialized variable in tx_invalid-test (practicalswift) Tree-SHA512: 1064cdd5c9e4612a05397a5880535d93dbb18dec4897b4bbda9e6ad78d30f4c72303e4d23159398f1b33545ff5819e739e374d7cde757e402b26c355268a2319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit the
errvariable was not guaranteed to be set before the check ...