Conversation
|
You need to submit secp256k1 changes upstream. |
|
Typo fixes in |
|
@fanquake Is https://github.com/bitcoin-core/secp256k1 the correct upstream repo for secp256k1? |
|
… On Sun, 29 Jan 2017 at 17:27, practicalswift ***@***.***> wrote:
@fanquake <https://github.com/fanquake> Perhaps a stupid question, but
what is the correct upstream repo for secp256k1?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9651 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA0t8s23XXvjxBcgpBGFbjlH5gvstXuaks5rXMvngaJpZM4Lw16e>
.
|
|
secp256k1 typos submitted in bitcoin-core/secp256k1#440 |
|
If you have more typos to fix or plan to do so, please include all
typo fixes in a single commit in this pull. This will aid review,
whereas multiple successive or parallel pull request to fix typos will
distract reviewers.
|
|
@MarcoFalke The only remaining typo fixes I have in store pertain to:
Are these of interest or is the policy to keep release notes/changelogs frozen post-release? |
|
We haven't been modifying old changelogs in this repo.
…On Sun, 29 Jan 2017 at 18:55, practicalswift ***@***.***> wrote:
@MarcoFalke <https://github.com/MarcoFalke> The only remaining typo fixes
I have in store pertain to:
- contrib/debian/changelog
- doc/release-notes/
Are these of interest of should release notes/changelogs be frozen
post-release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9651 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA0t8h4pgCxsWnOt7FvxWYNB6DAXXVsMks5rXOC1gaJpZM4Lw16e>
.
|
Historical changelog entries shouldn't be changed. If there is a critical mistake that can lead to funds loss of anyone reading it, or exploitable behavior, I'm sure an exception could be made. But not for typos. |
|
@laanwj Sounds reasonable! :-) I'll skip submitting the changelog typo PR |
5f62e3e Fix typos (practicalswift)
|
@laanwj Thanks for merging! We are now officially typo free :-) |
|
@practicalswift Good! :) |
5f62e3e Fix typos (practicalswift)
5f62e3e Fix typos (practicalswift)
5f62e3e Fix typos (practicalswift)
4 participants
A new round of typo fixes :-)