Net: Turn some methods and params/variables const#9659
Net: Turn some methods and params/variables const#9659laanwj merged 3 commits intobitcoin:masterfrom
Conversation
src/net.cpp
Outdated
There was a problem hiding this comment.
Even if we dont use it now, I'm not sure we want to get rid of passing flagInterruptMsgProc through...there is a strong case for using it in 0.15.
|
General concept ack, with the exception of removing the flagInterruptMsg pass (but please do make it const) |
|
Great, it seems I was right on leaving the last commit separated, I'll leave it out. |
jtimon
force-pushed
the
0.14-net-more-const
branch
from
9c0d421 to
0729102
Compare
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
utACK 0729102 (+/- SocketSendData being made const).
|
|
||
|
|
||
| // requires LOCK(cs_vSend) | ||
| size_t CConnman::SocketSendData(CNode *pnode) |
There was a problem hiding this comment.
Hmm...while technicall const for the CConnman, I'm not sure this "should be const" given that it is writing data to the peer itself...
There was a problem hiding this comment.
Well, writing to the peer itself here is writing to pnode, which isn't const, no?
|
utACK 0729102 |
4 participants
Also remove currently unused interruptMsgProc param from SendMessages.
I guess some squashing can be done (but I'm worried that interruptMsgProc is planned to be used in SendMessages later).