Conversation
|
ACK on bumping the minimum, as this is part of the release process https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#release-process Would be great if someone could prepare a pull for all those bumps, so it could be done prior to the branch off. Not sure if the other changes should go into 0.14. |
|
At least the changes that change translation messages cannot go into 0.14. |
luke-jr
force-pushed
the
intro_fixes
branch
2 times, most recently
from
e61c940 to
5bb2a5e
Compare
|
Stripped out the translation-touching stuff for now. I think this is good for 0.14. |
|
ACK 5bb2a5e |
src/qt/intro.cpp
Outdated
There was a problem hiding this comment.
This seems low.
118G /mnt/bitcoin/blocks
There was a problem hiding this comment.
Of which only
9.4G /mnt/bitcoin/blocks/index
(-txindex).
There was a problem hiding this comment.
We still store stale blocks forever (but those won't be downloaded in IBD).
There was a problem hiding this comment.
This is on a node which started sync last week, so it shouldnt have many stale blocks.
|
BLOCK_CHAIN_SIZE is meant to include some buffer, taking into account
when the next bump of this constant is planned. Otherwise it would
already be outdated when the software is released. I think you can
just round up to the next full 10 GB or something.
|
|
Okay, bumped it to 120. |
|
utACK a9baa6d |
1 similar comment
|
utACK a9baa6d |
|
I would hesitate to call this a bugfix that needs to happen last-hour for 0.14, as it seems rather inconsequential, but utACK a9baa6d. |
|
reACK a9baa6d |
|
Agree it's mostly an improvement, but we should get the blockchain size estimate update in. |
|
utACK a9baa6d
|
8 participants
No description provided.