AppInitMain: split initialization of Connman into a new function#9897
AppInitMain: split initialization of Connman into a new function#9897benma wants to merge 1 commit intobitcoin:masterfrom
Conversation
An effort to reduce the size of AppInitMain().
|
Rebased. |
|
concept ACK |
|
Ping @theuni (as he wrote the Connman code). |
theuni
left a comment
theuni
left a comment
There was a problem hiding this comment.
Mm, I like the consolidation, but this kinda confuses the interface and gets in the way of the clean instantiation. The things currently done before starting connman are actually just config options that haven't been moved in yet.
What I'd much prefer (just hadn't gotten around yet) is to add:
CConnman::Options::vWhitelist
CConnman::Options::vBinds
CConnman::Options::vSeedNodes
I think we can combine the approaches by keeping the creation as-is, and having InitConnman() parse the config options and return a CConnman::Options.
|
#10496 seems to be the next PR in this progression. |
|
Needs rebase after #10467 (I guess?) |
|
Might revisit with a new PR some day. |
6 participants
An effort to reduce the size of AppInitMain().