fixed typo in comment in netbase.h and bignum.h#995
Merged
sipa merged 1 commit intobitcoin:masterfrom Apr 2, 2012
Diapolo:master
Merged
fixed typo in comment in netbase.h and bignum.h#995sipa merged 1 commit intobitcoin:masterfrom Diapolo:master
sipa merged 1 commit intobitcoin:masterfrom
Diapolo:master
Conversation
Member
|
ACK |
Member
|
ACK, of course. But let's not break rc5 for it. |
Author
|
100% agreed ... only wanted to let you know :)! |
sipa
added a commit
that referenced
this pull request
Apr 2, 2012
fixed typo in comment in netbase.h and bignum.h
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
fixed typo in comment in netbase.h and bignum.h
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
* Improved exception handling - Removed attempts to catch exceptions in intermediate helper function calls - Made helper functions for JSON parsing private * Governance voting fixes - Converted voting defines to enums for better type safety - Enabled gobject voteraw rpc command - Removed unused parameter from gobject getvotes rpc command * Fixed help message for gobject get * Improved encapsulation of CGovernanceVote objects - CGovernanceVote data members are now private - Necessary to ensure that enum values are used for signals and outcomes since data members remain int's for compatibility with serialiation code * Removed unused cs_budget mutex (has been replaced with governance.cs) * Fix code review issues - Restored early return in ConvertVoteSignal - Removed special case for "none" string to make clear that NONE is for invalid strings - Removed commented defines (informational comments preserved) * Fixed code review issues - Fixed error messages for vote-conf, vote-alias and voteraw - Removed voteraw from gobject command list and help messages because it is actually a top-level command - Fixed parameter indices for voteraw
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Mar 8, 2018
Move checking of blockdownload timeout to the request manager
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 30, 2019
e06f7b6 [Tests] Minor optimizations in zerocoin_valid_public_spend test (random-zebra) cdc18ea [RPC] fix parameters check for spendzerocoin (missing ispublicspend) (random-zebra) 72bc39a [Tests] Add zerocoin_valid_public_spend to testRunner (random-zebra) 26045d3 [Consensus] Set zc PublicSpend version v3/v4 via SPORK (random-zebra) Pull request description: This follows bitcoin#936 It sets the required version for zerocoin PublicSpends via SPORK instead of having it height-based. When `SPORK_18_ZEROCOIN_PUBLICSPEND_V4` is not active (default), the required version is v3 (where old version 1 serials cannot be spent. ref: bitcoin#891 ). It also fixes the relative functional test `zerocoin_valid_public_spend.py` and adds it to the test_runner. ACKs for top commit: furszy: utACK e06f7b6 Warrows: utACK e06f7b6 Tree-SHA512: 07f18e77a91503f5d48dafad32364cc6292ffd1f9a3f9286a78de72dafc98b07342e6abd96eaabe55d20193f10be383c8d5bbac1b33c45712ade8c522e457b3f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I merge all file changes by hand from master into my own play-ground and that's why I stumple upon such small things ;).