Fix extended rpc tests broken by #9768#9972
Merged
maflcko merged 1 commit intobitcoin:masterfrom Mar 10, 2017
Merged
Conversation
Contributor
|
smartfees still fails for me with "log is not defined" |
2a1d7f8 to
d055bd6
Compare
Contributor
Author
|
Should be fixed. Can you try again? |
Member
|
Extended tests all pass for me now. ACK |
Member
|
Thanks and utACK d055bd6 |
maflcko
pushed a commit
that referenced
this pull request
Mar 10, 2017
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 of the extended qa tests were broken by #9768. This fixes them:
@MarcoFalke has proposed a fix for maxblocksinflight in #9971 and @sdaftuar has a fix for smartfees in #9970 . Both of those are fine and I'm happy to go with them as alternatives. This PR collects fixes for all three breaks in one place.