qt: Disable requests context menu actions when appropriate#214
Merged
maflcko merged 1 commit intobitcoin-core:masterfrom Feb 25, 2021
Merged
Conversation
Contributor
|
utACK 69915b8 - I guess comparing against zero for an "empty" amount is acceptable here. |
Contributor
Author
Comparing against zero is what's used to determine |
|
Concept ACK. |
Talkless
suggested changes
Feb 20, 2021
jarolrod
force-pushed
the
disable-contextactions-novalue
branch
from
69915b8 to
336a643
Compare
Contributor
Author
Member
|
Concept ACK. |
jarolrod
force-pushed
the
disable-contextactions-novalue
branch
from
336a643 to
3f83f05
Compare
Contributor
Author
|
updated from 336a643 -> 3f83f05, thanks @hebasto @MarcoFalke for the review Changes:
|
The recent requests table will allow you to copy data points even if they do not exist. This PR implements checks to disable the 'copy label', 'copy message', and 'copy amount' context menu action if the respective fields are empty.
jarolrod
force-pushed
the
disable-contextactions-novalue
branch
from
3f83f05 to
bb3da8f
Compare
Contributor
Author
hebasto
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent requests table will allow you to copy data points even if they do not exist. This PR implements checks to disable the
copy label,copy message, andcopy amountcontext menu actions if the respective fields are empty. This brings the recent requests table context menu behavior closer to the behavior seen in the transaction view.On a payment request entry which does not have a value for label, message, or amount:
copy URInever needs to be disabled as an entry in the recent requests table must have a URI even if it doesn't have a label, message, or amount. #213 will add acopy addresscontext menu action. This also does not need a check as an entry must be associated with an address.Below are some more examples of how this PR will behave:
Has Label, Message, and Amount
Has Label and Amount, but no Message
