qt, refactor: rpcconsole translatable string fixes and improvements#221
Merged
maflcko merged 2 commits intobitcoin-core:masterfrom Mar 7, 2021
Merged
Conversation
jonatack
force-pushed
the
qt-rpcconsole-translation-improvements
branch
from
e1a10ff to
17edc9a
Compare
jonatack
commented
Feb 23, 2021
jonatack
force-pushed
the
qt-rpcconsole-translation-improvements
branch
from
17edc9a to
52d10ee
Compare
hebasto
approved these changes
Feb 23, 2021
hebasto
reviewed
Feb 24, 2021
jonatack
force-pushed
the
qt-rpcconsole-translation-improvements
branch
from
52d10ee to
2e2fe50
Compare
hebasto
approved these changes
Feb 24, 2021
Member
Author
|
Rebased following merge of #226, dropped "Never" from the struct as it is now only used once. |
jonatack
force-pushed
the
qt-rpcconsole-translation-improvements
branch
from
2e2fe50 to
3d85e92
Compare
hebasto
approved these changes
Feb 25, 2021
Talkless
reviewed
Feb 28, 2021
| void cmdRequest(const QString &command, const WalletModel* wallet_model); | ||
|
|
||
| private: | ||
| struct TranslatedStrings { |
There was a problem hiding this comment.
Interesting technique. I guess translators will see TranslatedStrings as location, not rpcconsole.h? But I guess that doesn't matter, not much context needed?
There was a problem hiding this comment.
I've tried with some small test project, and lupdate/linguist uses parent class as context, so no issues here.
and in the touched lines: - replace 2 occurrences of `== ""` with `isEmpty()` - replace an unneeded `+=` with `=`
and add missing braces to the touched conditionals. Co-authored-by: Hennadii Stepanov <[email protected]>
jonatack
force-pushed
the
qt-rpcconsole-translation-improvements
branch
from
3d85e92 to
6242bee
Compare
Member
Author
|
Updated with suggestion from @Talkless (thanks!) to replace |
hebasto
approved these changes
Feb 28, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 8, 2021
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPCConsoleclass for reuse