macOS theme switching not supported#268
Closed
jarolrod wants to merge 1 commit intobitcoin-core:masterfrom
Closed
Conversation
Document that theme switching on macOS, switching between light and dark mode, is currently broken.
Member
|
Hoping #275 will make this change unnecessary :) |
Member
|
Is this really needed now? |
Contributor
Author
hebasto
added a commit
that referenced
this pull request
May 28, 2021
c231254 qt: Make TransactionView aware of runtime palette change (Hennadii Stepanov) 2b622d4 qt: Make CoinControlDialog aware of runtime palette change (Hennadii Stepanov) 97a6b5e qt: Make OverviewPage aware of runtime palette change (Hennadii Stepanov) d05f1b2 qt: Make UnitDisplayStatusBarControl aware of runtime palette change (Hennadii Stepanov) 6b2ce65 qt: Replace base class of ClickableLabel with ThemedLabel (Hennadii Stepanov) ff530a2 qt: Use GUIUtil::ThemedLabel class (Hennadii Stepanov) d99ef32 qt: Add GUIUtil::ThemedLabel class (Hennadii Stepanov) c054720 qt: Make SignVerifyMessageDialog aware of runtime palette change (Hennadii Stepanov) 0dcc3fa qt: Make SendCoinsEntry aware of runtime palette change (Hennadii Stepanov) fa18d28 qt: Make RPCConsole aware of runtime palette change (Hennadii Stepanov) f108382 qt: Make BitcoinGUI aware of runtime palette change (Hennadii Stepanov) ce17861 qt: Make PlatformStyle aware of runtime palette change (Hennadii Stepanov) Pull request description: On macOS switching appearance (Light -> Dark or Dark -> Light) when Bitcoin Core is running makes the GUI pretty unusable. This bug is especially important when a user chose the "Auto" mode to adjust appearance automatically. This PR fixes Bitcoin Core behavior. This is an alternative to #268. ACKs for top commit: Sjors: tACK c231254 on macOS 11.4 goums: ACK c231254 promag: Tested ACK c231254 on macOS Big Sur arm64. jarolrod: tACK c231254 Tree-SHA512: 122dda3e4c9703f68cec60613c536ca59d04c93f2c03398559f2361b8d279ae534800e8e677d94a33e10e769d00be54295a704e98afa2e986a06146b9f164854
Contributor
Author
|
Closing since #275 was merged 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was originally believed that theme switching on macOS was broken only on macOS 10.14: #154 (comment), #154 (review)
It is actually broken on
CatalinaandBig Suras well (building and compiling off master). When switching from one theme to another the Icons do not get re-colorized.This PR documents that theme switching is not currently supported in the release notes. Based on #154 (comment), but drops the macOS 10.14 part.
Below are screenshots that were taken on
Big Surwhich show this behavior. The same occurs onCatalina.Light Mode to Dark Mode
Dark Mode to Light Mode