Skip to content

Elide long strings in their middle in the Peers tab#276

Merged
hebasto merged 1 commit intobitcoin-core:masterfrom
hebasto:210410-elide
Apr 19, 2021
Merged

Elide long strings in their middle in the Peers tab#276
hebasto merged 1 commit intobitcoin-core:masterfrom
hebasto:210410-elide

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Apr 10, 2021 •
edited
Loading

The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was discussed in #262.

On master (f0fa324):
DeepinScreenshot_select-area_20210410141435

With this PR:
DeepinScreenshot_select-area_20210410140430

This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless.

@hebasto hebasto mentioned this pull request Apr 10, 2021
Closed
@jonatack
Copy link
Member

jonatack commented Apr 10, 2021

Concept ACK, this looks like a real and practical improvement.

promag
promag reviewed Apr 10, 2021
View reviewed changes
Copy link
Contributor

@promag promag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Why does it only show ellipsis on the 1st screenshot?

@hebasto
Copy link
Member Author

hebasto commented Apr 10, 2021 via email

jarolrod
jarolrod reviewed Apr 11, 2021
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 4e06133

tested on macOS 11.2.3 Qt 5.15.2

Screen Shot 2021-04-11 at 5 49 33 PM

promag
promag reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 4e06133.

Unfortunately, Qt doesn't support setting elide mode per column. This PR changes elide mode for all columns but along with minimum columns, it's actually a nice change.

@hebasto hebasto merged commit 13d27b4 into bitcoin-core:master Apr 19, 2021
@promag
Copy link
Contributor

promag commented Apr 19, 2021

🎉

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 19, 2021
@hebasto
Merge bitcoin-core/gui#276: Elide long strings in their middle in the…
3b2479c 
… Peers tab

4e06133 qt: Elide long strings in their middle in the Peers tab (Hennadii Stepanov)

Pull request description:

  The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was [discussed](bitcoin-core/gui#262 (comment)) in #262.

  On master (f0fa324):
  ![DeepinScreenshot_select-area_20210410141435](https://user-images.githubusercontent.com/32963518/114267903-24eea400-9a07-11eb-8c80-99f68d5cc522.png)

  With this PR:
  ![DeepinScreenshot_select-area_20210410140430](https://user-images.githubusercontent.com/32963518/114267796-83675280-9a06-11eb-921f-ca47c2075496.png)

  This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless.

ACKs for top commit:
  jarolrod:
    tACK 4e06133
  promag:
    Code review ACK 4e06133.

Tree-SHA512: 1d5a62afb1152029e69fccea2ae53dcb262a91724a5c03dfc4de8c409b280814d0c211c2f9a71f1a6e927f4ed571ba4ac311de9de8ebb797eaf1051674241bdb
@hebasto hebasto deleted the 210410-elide branch April 20, 2021 19:50
@jarolrod jarolrod mentioned this pull request May 24, 2021
Closed
barton2526 added a commit to barton2526/Gridcoin-Research that referenced this pull request Jul 17, 2021
@barton2526
Elide long strings in their middle in the Peers tab
0c69fb8 
Ref: bitcoin-core/gui#276
barton2526 added a commit to barton2526/Gridcoin-Research that referenced this pull request Jul 17, 2021
@barton2526
Elide long strings in their middle in the Peers tab
f50640b 
Ref: bitcoin-core/gui#276
@barton2526 barton2526 mentioned this pull request Jul 17, 2021
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 21, 2021
@hebasto @PastaPastaPasta
Merge bitcoin-core/gui#276: Elide long strings in their middle in the…
f8802b4 
… Peers tab

4e06133 qt: Elide long strings in their middle in the Peers tab (Hennadii Stepanov)

Pull request description:

  The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was [discussed](bitcoin-core/gui#262 (comment)) in dashpay#262.

  On master (f0fa324):
  ![DeepinScreenshot_select-area_20210410141435](https://user-images.githubusercontent.com/32963518/114267903-24eea400-9a07-11eb-8c80-99f68d5cc522.png)

  With this PR:
  ![DeepinScreenshot_select-area_20210410140430](https://user-images.githubusercontent.com/32963518/114267796-83675280-9a06-11eb-921f-ca47c2075496.png)

  This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless.

ACKs for top commit:
  jarolrod:
    tACK 4e06133
  promag:
    Code review ACK 4e06133.

Tree-SHA512: 1d5a62afb1152029e69fccea2ae53dcb262a91724a5c03dfc4de8c409b280814d0c211c2f9a71f1a6e927f4ed571ba4ac311de9de8ebb797eaf1051674241bdb
pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021
@hebasto @pravblockc
Merge bitcoin-core/gui#276: Elide long strings in their middle in the…
90c6e99 
… Peers tab

4e06133 qt: Elide long strings in their middle in the Peers tab (Hennadii Stepanov)

Pull request description:

  The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was [discussed](bitcoin-core/gui#262 (comment)) in dashpay#262.

  On master (f0fa324):
  ![DeepinScreenshot_select-area_20210410141435](https://user-images.githubusercontent.com/32963518/114267903-24eea400-9a07-11eb-8c80-99f68d5cc522.png)

  With this PR:
  ![DeepinScreenshot_select-area_20210410140430](https://user-images.githubusercontent.com/32963518/114267796-83675280-9a06-11eb-921f-ca47c2075496.png)

  This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless.

ACKs for top commit:
  jarolrod:
    tACK 4e06133
  promag:
    Code review ACK 4e06133.

Tree-SHA512: 1d5a62afb1152029e69fccea2ae53dcb262a91724a5c03dfc4de8c409b280814d0c211c2f9a71f1a6e927f4ed571ba4ac311de9de8ebb797eaf1051674241bdb
gades pushed a commit to cosanta/cosanta-core that referenced this pull request May 9, 2022
@hebasto @gades
Merge bitcoin-core/gui#276: Elide long strings in their middle in the…
ac3b2a7 
… Peers tab

4e06133 qt: Elide long strings in their middle in the Peers tab (Hennadii Stepanov)

Pull request description:

  The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was [discussed](bitcoin-core/gui#262 (comment)) in dashpay#262.

  On master (f0fa324):
  ![DeepinScreenshot_select-area_20210410141435](https://user-images.githubusercontent.com/32963518/114267903-24eea400-9a07-11eb-8c80-99f68d5cc522.png)

  With this PR:
  ![DeepinScreenshot_select-area_20210410140430](https://user-images.githubusercontent.com/32963518/114267796-83675280-9a06-11eb-921f-ca47c2075496.png)

  This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless.

ACKs for top commit:
  jarolrod:
    tACK 4e06133
  promag:
    Code review ACK 4e06133.

Tree-SHA512: 1d5a62afb1152029e69fccea2ae53dcb262a91724a5c03dfc4de8c409b280814d0c211c2f9a71f1a6e927f4ed571ba4ac311de9de8ebb797eaf1051674241bdb
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge 13d27b4 into merged_master (Bitcoin PR bitcoin-core/gui#276)
73880cb
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@promag promag promag left review comments

@jarolrod jarolrod jarolrod left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Design Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hebasto @jonatack @promag @jarolrod