Avoid unnecessary translations#297
Conversation
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
ACK 19d51a2
Tested that these are all the occurrences in this file, and cross-checked for any occurrences in other files. We already set the notr attribute in other areas of the code such as coincontroldialog.ui, overviewpage.ui, and sendcoinsdialog.ui.
Furthermore, BTC is treated as a symbol or unit of Bitcoin and is untranslatable by nature.
|
Concept ACK |
|
Is it really untranslated? What about languages that don't use the Latin alphabet at all? |
For example? (not non-Latin languages, but abbreviated name "BTC" in non-Latin languages) My three non-Latin languages use "BTC", btw. |
|
I would expect Russian to use a Cyrillic abbreviation? Possibly Chinese and Japanese to get single-character units at some point? |
I've made a quick re-check of some multi-language online services. All of them use "BTC" in non-Latin languages. |
5 participants
Working on translation, I found these translations introduced in #79, that are unnecessary (assuming the universal nature of the "BTC" string).