@jarolrod

Did you consider how it will look on a long-running node when one-digit id peer is next to, say, four-digit id one?

@hebasto Actually, that's a good point. As a tabular figure, perhaps it makes more sense to leave as-is. Especially, if we enforce a monospace font at some point

Update from 4ed95c0 -> 73a91c6

Changes:

• Keep Peer # left-aligned as this is more appropriate for a tabular figure

• renames the peers tab column header from Peer Id to Peer to allow resizing the column more tightly

If saving of the horizontal space is the motivation, leaving just "ID" or "id" is strictly better approach for the following reasons:

• the translated "Peer" could become much longer, e.g., the both variants in Ukrainian are "Вузол" or "З'єднання"
• "ID"/"id" is shorter, and often remains untranslated

Also, #290 (comment)

Did you consider how it will look on a long-running node when one-digit id peer is next to, say, four-digit id one?

I considered it carefully and described some of that process in the parent PR description: "center-aligns the entries in the Peer column to align them under the column header rather than to the left (I also tried right-alignment but the values are unreadably close to the Address values and it seems more esthetic to be aligned under the header)."

Ideally they would be right-justified like in -netinfo. Center is still ok and under the header. Left for numbers doesn't make sense to me.

leaving just "ID" or "id" is strictly better approach

Hm, I disagree for the reasons I already described in the parent PR.

For laypeople (not devs or database people), the right word here is probably "number", "peer number" or just "peer", as "number" is self-understood. Of those three, peer is the shortest, and shorter than 4 characters doesn't make sense to consider as these peer numbers don't take long to reach 5+ digits anyway.

"ID" means "identification" and in common use, your ID card. "Show me some ID" is what the police officer or the security guard would ask you.

"Id" is a word from Freudian psychology IIRC.

Maybe a good solution is to have native speakers of each language decide on the best word for that language, and in cases where the English-as-a-first-language and English-as-a-second-language-or-as-dev-jargon differ, provide helpful translation hints in the translator comments.

Maybe a good solution is to have native speakers of each language decide on the best word for that language, and in cases where the English-as-a-first-language and English-as-a-second-language-or-as-dev-jargon differ, provide helpful translation hints in the translator comments.

Agree!

№ - numero will work..

https://en.wikipedia.org/wiki/Numero_sign

https://github.com/RandyMcMillan/gui/tree/numero-column-name

RandyMcMillan@23dbd90#diff-3fcbd1d49f399ac9b4656011ea03e7ef80a855482d6de33855e6326ec065321fR77

№ - numero will work..

https://en.wikipedia.org/wiki/Numero_sign

Interesting, it is a standard abbreviation in French, TIL it exists in English. I like it better than ID, not sure how well known it is and what the GUI policy is regarding signs/symbols/abbreviations.

Agree to use any neutral replacement for "id" string, even just "#" for English locale :)
https://en.wikipedia.org/wiki/Number_sign

These column headers are words, so for the English I would suggest using "Peer" and then describe alternatives ("This column means the peer number or ID") for translators in the tr comment.

It seem this PR needs translation comments only :)

Honest opinion here, could be empty. Otherwise ID or # LGTM.

In this old PR #135 "ID" looked ok...

Updated from 73a91c6 -> b405f19 (pr311.02, pr311.03, diff)

Changes:

• added translator comments for the columns of the Peers Table to address this comment. Hopefully, this translator comment is enough to guide the translation of the term and can appease all sides on the debate of ID vs Peer

updated from b405f19 -> 657b33e (pr311.03, pr311.04, diff)

Changes:
Updated to address review comments on the translator comment contents, thanks @hebasto and @jonatack!

Here is a diff of how I've taken your suggestions and updated from pr311.03:

diff --git a/src/qt/peertablemodel.h b/src/qt/peertablemodel.h
index 268ae013e..3d195342f 100644
--- a/src/qt/peertablemodel.h
+++ b/src/qt/peertablemodel.h
@@ -79,27 +79,25 @@ private:
             unique number used to identify a connection. */
         tr("Peer"),
         /*: Title of Peers Table column which contains the
-            IP/Onion/I2P address we used to connect to the peer. */
+            IP/Onion/I2P address of the connected peer. */
         tr("Address"),
-        /*: Title of Peers Table column which contains a value for
-            the type of connection we have established with the peer.
-            Type is a term denoting what the connection is for. */
+        /*: Title of Peers Table column which describes the type of
+            peer connection. The "type" describes why the connection exists. */
         tr("Type"),
-        /*: Title of Peers Table column which contains a value for
-            the network the peer resides on. */
+        /*: Title of Peers Table column which states the network the peer
+            connected through. */
         tr("Network"),
-        /*: Title of Peers Table column which contains a value for
-            the latency of the connection established with the peer. */
+        /*: Title of Peers Table column which indicates the current latency
+            of the connection with the peer. */
         tr("Ping"),
-        /*: Title of Peers Table column which contains a value for
-            the total amount of bytes we have sent to the peer. */
+        /*: Title of Peers Table column which indicates the total amount of
+            network information we have sent to the peer. */
         tr("Sent"),
-        /*: Title of Peers Table column which contains a value for
-            the total amount of bytes we have received from the peer. */
+        /*: Title of Peers Table column which indicates the total amount of
+            network information we have received from the peer. */
         tr("Received"),
         /*: Title of Peers Table column which contains the peer's
-            User Agent string. A peer can configure this value to
-            allow itself to be identifiable. */
+            User Agent string. */
         tr("User Agent")};
     std::unique_ptr<PeerTablePriv> priv;
     QTimer *timer;

utACK 657b33e