Fix regression in "Encrypt Wallet" menu item#393
Merged
hebasto merged 1 commit intobitcoin-core:masterfrom Aug 5, 2021
Merged
Conversation
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections.
hebasto
added
Bug
Member
Author
Member
|
ACK d54d949 Tested that this fixes the issue. For those wondering why this fixes the issue, |
jarolrod
reviewed
Aug 5, 2021
Contributor
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
ACK d54d949
Tested on macOS 12 and Ubuntu 20.4.02
The related code is a bit entangled, but I have ensured that this is correct in its implementation and is a good way to fix the issue. Below are screenshots comparing master and this PR:
| Master. | PR. |
|---|---|
 |
 |
This was tested by starting with an already encrypted wallet. On the master branch, we can notice the issue described in #392. On the PR branch, we can see that this is fixed.
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 5, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
Member
Author
|
Backported in bitcoin/bitcoin#22629. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 5, 2021
d54d949 qt: Fix regression in "Encrypt Wallet" menu item (Hennadii Stepanov) Pull request description: Fix #392. Adding a new item to the `m_wallet_selector` must follow the establishment of a connection between the `WalletView::encryptionStatusChanged` signal and the `BitcoinGUI::updateWalletStatus` slot. This was a regression introduced in bitcoin@20e2e24 (#29). --- An _encrypted_ wallet being auto-loaded at the GUI startup: - on master (eaf09bd)  - with this PR  ACKs for top commit: achow101: ACK d54d949 jarolrod: ACK d54d949 Tree-SHA512: 669615ec8e1517c2f4cdf59bd11a7c85be793ba0dda112361cf95e6c2f0636215fed331d26a86dc9b779a49defae1b248232f98dab449584376c111c288e87bb
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 6, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 6, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 6, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 7, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 9, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 9, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
laanwj
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Aug 26, 2021
32e1424 Fix build with Boost 1.77.0 (Rafael Sadowski) cb34a0a qt: Handle new added plurals in bitcoin_en.ts (Hennadii Stepanov) 068985c doc: Mention the flat directory structure for uploads (Andrew Chow) 27d43e5 guix: Don't include directory name in SHA256SUMS (Andrew Chow) 88fb7e3 test: fix bug in 22686 (S3RK) 63fec7e clientversion: No suffix #if CLIENT_VERSION_IS_RELEASE (Carl Dong) dfaffbe test: Test for ApproximateBestSubset edge case with too little fees (Andrew Chow) e86b023 wallet: Assert that enough was selected to cover the fees (Andrew Chow) ffc81e2 wallet: Use GetSelectionAmount for target value calculations (Andrew Chow) ce77b45 release: Release with separate SHA256SUMS and sig files (Carl Dong) cb491bd guix-verify: Non-zero exit code when anything fails (Carl Dong) 6a611d2 gui: ensure external signer option remains disabled without signers (Andrew Chow) e9b4487 qt: Fix regression in "Encrypt Wallet" menu item (Hennadii Stepanov) 57fce06 consensus/params: simplify ValidDeployment check to avoid gcc warning (Anthony Towns) e9d30fb ci: Run fuzzer task for the master branch only (Hennadii Stepanov) Pull request description: Backported: 1) #22730 1) bitcoin-core/gui#393 1) #22597 1) bitcoin-core/gui#396 1) #22643 1) #22642 1) #22685 1) #22686 1) #22654 1) #22742 1) bitcoin-core/gui#406 1) #22713 ACKs for top commit: laanwj: Code list-of-backported-PRs review ACK 32e1424 Tree-SHA512: f5e2dd1be6cdcd39368eeb5d297b3ff4418d0bf2e70c90e59ab4ba1dbf16f773045d877b4997511de58c3aca75a978dcf043e338bad23951557e2a27ccc845f6
fujicoin
added a commit
to fujicoin/fujicoin-22.0
that referenced
this pull request
Aug 27, 2021
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d94959869b0c363939163b99ba0475751dcb6
gwillen
pushed a commit
to gwillen/elements
that referenced
this pull request
Jul 27, 2022
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
gwillen
pushed a commit
to gwillen/elements
that referenced
this pull request
Aug 1, 2022
Adding a new item to the m_wallet_selector must follow the establishment of signal-slot connections. Github-Pull: bitcoin-core/gui#393 Rebased-From: d54d949
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #392.
Adding a new item to the
m_wallet_selectormust follow the establishment of a connection between theWalletView::encryptionStatusChangedsignal and theBitcoinGUI::updateWalletStatusslot.This was a regression introduced in bitcoin/bitcoin@20e2e24 (#29).
An encrypted wallet being auto-loaded at the GUI startup: