Merged
Conversation
promag
reviewed
Jul 26, 2020
| <widget class="QLabel" name="label_3"> | ||
| <property name="text"> | ||
| <string>Current number of blocks</string> | ||
| <string>Current block height</string> |
Contributor
There was a problem hiding this comment.
Funny that "height" is not in the translations.
Contributor
|
ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations. |
Contributor
|
Member
Author
|
Contributor
|
Fair enough. I wanted to show that both wordings are used, so it seems arbitrary to change only one? |
Contributor
|
cr ACK b6dcc6d probably doesn't matter much, but shouldn't hurt either |
Member
Author
In the GUI this is one, I guess. |
Contributor
|
block height is probably better because it implies linearity (chain) instead of number of blocks, which could also mean the number of blocks in the block tree. |
Member
Author
Exactly. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 28, 2020
b6dcc6d gui: Clarify block height label (Hennadii Stepanov) Pull request description: Prefer "block height" instead of "number of blocks". This was done while testing bitcoin#16981. ACKs for top commit: michaelfolkson: ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations. MarcoFalke: cr ACK b6dcc6d Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Dec 3, 2020
laanwj
pushed a commit
that referenced
this pull request
Dec 9, 2020
b5ef9be675 Merge #1: Merge changes from upstream 9e7f512430 Merge remote-tracking branch 'origin/master' into bitcoin-fork 1f85030246 Add support for ARM64 darwin (#43) 3bb959c982 Remove unnecessary reinterpret_cast (#42) 2e97ab26b1 Fix (unused) ReadUint64LE for BE machines (#41) 47b40d2209 Bump dependencies. (#40) ba74185625 Move CI to Visual Studio 2019. efa301a7e5 Allow different C/C++ standards when this is used as a subproject. cc6d71465e CMake: Use configure_package_config_file() git-subtree-dir: src/crc32c git-subtree-split: b5ef9be6755a2e61e2988bb238f13d1c0ee1fa0a
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Mar 22, 2021
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
b6dcc6d gui: Clarify block height label (Hennadii Stepanov) Pull request description: Prefer "block height" instead of "number of blocks". This was done while testing bitcoin#16981. ACKs for top commit: michaelfolkson: ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations. MarcoFalke: cr ACK b6dcc6d Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 16, 2021
b6dcc6d gui: Clarify block height label (Hennadii Stepanov) Pull request description: Prefer "block height" instead of "number of blocks". This was done while testing bitcoin#16981. ACKs for top commit: michaelfolkson: ACK b6dcc6d. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations. MarcoFalke: cr ACK b6dcc6d Tree-SHA512: ec3b48c1af5d613ed657ad51f2caddea774376736ecc02343d54518986e35ec37f1745b059814b5be92b5e5c2bb2970d17159b24c6e88b9316803d4de5327c31
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 16, 2021
Summary: > Prefer "block height" instead of "number of blocks". This is a backport of [[bitcoin-core/gui#40 | core-gui#40]] Test Plan: `ninja && src/qt/bitcoin-qt` Menu Window > Information Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer "block height" instead of "number of blocks".
This was done while testing bitcoin/bitcoin#16981.